Update incorrect GettingStarted CDN instructions#1852
Merged
mattelen merged 1 commit intoshentao:masterfrom Feb 24, 2026
Merged
Update incorrect GettingStarted CDN instructions#1852mattelen merged 1 commit intoshentao:masterfrom
mattelen merged 1 commit intoshentao:masterfrom
Conversation
The project moved from exposing itself from "window.VueMultiselect" to "window['vue-multiselect']" when it transictioned to 3.0.
|
This code worked for me. |
|
Project maintainers should accept this commit and fix the documentation, This has bitten me twice now. |
mattelen
requested review from
Copilot and
mattelen
and removed request for
mattelen
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect CDN usage documentation for vue-multiselect 3.x. The documentation incorrectly stated that the library is exposed as window.VueMultiselect when loaded via CDN, but the UMD build (which is served by unpkg) actually exposes it as window['vue-multiselect']. This caused confusion for users trying to use the library via CDN, as reported in issue #1756.
Changes:
- Updated CDN usage example to use
window['vue-multiselect'].defaultinstead ofwindow.VueMultiselect.default
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattelen
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed through this issue that the documentation in the main page of the project is incorrect, since it mentions using
window.VueMultiselect.Afaik, the project moved from exposing itself from
window.VueMultiselecttowindow['vue-multiselect']when it transitioned to 3.X.