fix: update keypress event to keydown#1907
Conversation
f37a197 to
59149ae
Compare
|
Keypress event is deprecated and unsupported by some browser versions. |
|
Hi @akki-jat, it's my first time contributing to open source so wanted to check on how do I go about releasing a patch version for this? |
|
Hi @jk-leong. Thanks for your first contribution to open source! So its landed in the master branch, ready for the next release. From a quick browse of the MDN doc you provided, it looks like this is still working for browsers, so I was going to release as part of the next one, instead of making a release specifically for it. In saying that, if I have missed something, or if you are using a browser that is no longer supporting the old way, I can do a release on this - let me know In any case, I'm wanting to do a release when #1914 is completed, which will be in the next 2-3 weeks. If it can wait till then, then it will go out with that |
|
Hi @mattelen !! Very excited that I am able to contribute 😀 No rush on the release, just curious about how it works. |
Updating keypress event to keydown event to ensure long term browser support