Skip to content

fix: update keypress event to keydown#1907

Merged
akki-jat merged 1 commit intoshentao:masterfrom
jk-leong:fix-keypress-to-keydown
Jul 26, 2025
Merged

fix: update keypress event to keydown#1907
akki-jat merged 1 commit intoshentao:masterfrom
jk-leong:fix-keypress-to-keydown

Conversation

@jk-leong
Copy link
Copy Markdown
Contributor

Updating keypress event to keydown event to ensure long term browser support

@jk-leong jk-leong force-pushed the fix-keypress-to-keydown branch from f37a197 to 59149ae Compare July 18, 2025 09:46
@jk-leong
Copy link
Copy Markdown
Contributor Author

Keypress event is deprecated and unsupported by some browser versions.
https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event

@akki-jat akki-jat self-assigned this Jul 26, 2025
@akki-jat akki-jat merged commit 3845889 into shentao:master Jul 26, 2025
@jk-leong jk-leong deleted the fix-keypress-to-keydown branch July 30, 2025 05:57
@jk-leong
Copy link
Copy Markdown
Contributor Author

Hi @akki-jat, it's my first time contributing to open source so wanted to check on how do I go about releasing a patch version for this?

@akki-jat
Copy link
Copy Markdown
Collaborator

akki-jat commented Jul 30, 2025

@jk-leong - @mattelen takes care of releasing the new version.

@mattelen please check.

@mattelen
Copy link
Copy Markdown
Collaborator

Hi @jk-leong. Thanks for your first contribution to open source!

So its landed in the master branch, ready for the next release. From a quick browse of the MDN doc you provided, it looks like this is still working for browsers, so I was going to release as part of the next one, instead of making a release specifically for it.

In saying that, if I have missed something, or if you are using a browser that is no longer supporting the old way, I can do a release on this - let me know

In any case, I'm wanting to do a release when #1914 is completed, which will be in the next 2-3 weeks. If it can wait till then, then it will go out with that

@jk-leong
Copy link
Copy Markdown
Contributor Author

jk-leong commented Aug 1, 2025

Hi @mattelen !! Very excited that I am able to contribute 😀

No rush on the release, just curious about how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants