Skip to content

Make teleport an option via a prop#1910

Merged
mattelen merged 2 commits intomasterfrom
1909-wouldve-been-nice-to-make-teleport-an-option
Jul 25, 2025
Merged

Make teleport an option via a prop#1910
mattelen merged 2 commits intomasterfrom
1909-wouldve-been-nice-to-make-teleport-an-option

Conversation

@mattelen
Copy link
Copy Markdown
Collaborator

Add new prop called useTeleport, defaulting to false, so teleport is optional

@mattelen mattelen self-assigned this Jul 25, 2025
@mattelen mattelen linked an issue Jul 25, 2025 that may be closed by this pull request
@mattelen mattelen requested a review from akki-jat July 25, 2025 11:47
@mattelen
Copy link
Copy Markdown
Collaborator Author

Thanks for the approval @akki-jat. Question, do you think this should be released as a minor or major version? I released the new teleport feature (Which forced everyone to use it) as a minor, but some people weren't happy with that. In hindsight, might not have been a great idea.

I'm thinking releasing this as a minor, so then it stops breaking 3.x version pipeline. Do you think this is the best way to go, or shall I do a version 4 major release?

@akki-jat
Copy link
Copy Markdown
Collaborator

akki-jat commented Jul 25, 2025

Thanks for the approval @akki-jat. Question, do you think this should be released as a minor or major version? I released the new teleport feature (Which forced everyone to use it) as a minor, but some people weren't happy with that. In hindsight, might not have been a great idea.

I'm thinking releasing this as a minor, so then it stops breaking 3.x version pipeline. Do you think this is the best way to go, or shall I do a version 4 major release?

@mattelen I think we should release a patch / minor version. So, it would be easy for the user / automatic upgrade to newer version.

@mattelen mattelen merged commit e0d3b48 into master Jul 25, 2025
@lehni
Copy link
Copy Markdown

lehni commented Jul 26, 2025

thank you for taking care of this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Would've been nice to make teleport an option

3 participants