Skip to content

Browserify es6 transform support.#44

Merged
shentao merged 1 commit intoshentao:masterfrom
asvae:es6-browserify-support
Jun 24, 2016
Merged

Browserify es6 transform support.#44
shentao merged 1 commit intoshentao:masterfrom
asvae:es6-browserify-support

Conversation

@asvae
Copy link
Copy Markdown
Contributor

@asvae asvae commented Jun 24, 2016

Required to hint browserify that *.vue files should be babelified.
Without it, you get plain es6, which is not digestible by many browsers.

@shentao
Copy link
Copy Markdown
Owner

shentao commented Jun 24, 2016

I'm not a Browserify user myself, so I trust this would help in case someone would wish to import the .vue component itself. Right now if you use the default import, you get an already transpiled es5 module.

@asvae
Copy link
Copy Markdown
Contributor Author

asvae commented Jun 24, 2016

@shentao yeah, I imported component directly (to apply fix). This pull request makes no much sense in terms of using precompiled bundle.

@shentao
Copy link
Copy Markdown
Owner

shentao commented Jun 24, 2016

Fine with me! Merging!

@shentao shentao merged commit 1d57e90 into shentao:master Jun 24, 2016
@shentao
Copy link
Copy Markdown
Owner

shentao commented Jun 24, 2016

BTW. What kind of fix is it? Are you extending the component? Have you thought about using the mixins to create a similar component? I'm planning on creating few examples of such custom components like search with images (similar to the one in IMDb) or more complex dropdowns like the one on github when you hover over the watch option.

@asvae
Copy link
Copy Markdown
Contributor Author

asvae commented Jun 24, 2016

@shentao I'm talking about this one.

Have you thought about using the mixins to create a similar component?

Yeah, I plan to use them in future. Gonna get somewhat more complex formatting. Also thinking of modal onclick select. Code vise the library is very good so far, and it fits my objective/reactive paradigm (meaning all selects work with objects and going fine).

For now, I just did an assortment of wrappers on your Multiselect.vue component for different use cases. Gonna redesign them at some point :3. Possibly.

@asvae asvae deleted the es6-browserify-support branch June 24, 2016 18:44
@shentao
Copy link
Copy Markdown
Owner

shentao commented Jun 25, 2016

Sounds great! The idea is to create some more complex examples for everyone to use. The idea of selecting stuff is quite powerful. That’s why it was important to extract most of the code behind it into mixins to encourage others to play with it. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants