Return SignedRankTest objects, allow to use the built-in plot() methods in baycomp#20
Merged
Merged
Conversation
Owner
|
Thanks for this contribution @Daniel300000! Great idea to expose this. The change itself looks good. However, before accepting two things need to be done:
|
Contributor
Author
|
Thanks for merging the pull request! It seems that I was a little bit too fast with my commit, sorry. Should we also update the description? For example: What would be the new version on PyPI? Version 1.2.0? |
Owner
|
Yes, next will be 1.2.0. If you want to update the documentation, add a link directly to the relevant part of baycomp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added another attribute 'sample_matrix' for the SignedRankTest objects from the package 'baycomp'.
One can then use them to draw some plots, e.g.: