Add missing shipping detail argument. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused an error when loading the order detail page for an order created in Magento 1.
|
Thanks for submitting this @cykirsch we'll review |
wsajosh
approved these changes
Jan 26, 2018
Contributor
wsajosh
left a comment
wsajosh
left a comment
There was a problem hiding this comment.
This was excluded accidentally. It's required in order to get the address valid status as well as all info held in the carrier group shipping details such as origin information, delivery dates and carrier details
TravisBernard
pushed a commit
that referenced
this pull request
Dec 3, 2018
SHQ16-2141 UPS LTL use carrier code as type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused an error when loading the order detail page for an order created in Magento 1.