replicated a magento patch see details here https://support.magento.c… #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/hc/en-us/articles/360058863531-MDVA-33289-Magento-patch-Javascript-in-address-at-checkout without this I get javascript displayed after the street address on the payment part of the checkout (using braintree) the link is to the magento patch for this, this change stops the patch being overwritten. Im not sure if this is needed on the shipping-information file as well, but i dont seem to get any issues without it.
|
This issue is also effecting ShipperHQ/AddressAutocomplete since it uses module-shipper as a dependency. If this is all good, can this be merged sooner rather than later? |
Contributor
|
Thanks @leedyche ! We're approved this and are preparing to get it released shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replicated a magento patch see details here https://support.magento.com/hc/en-us/articles/360058863531-MDVA-33289-Magento-patch-Javascript-in-address-at-checkout without this I get javascript displayed after the street address on the payment part of the checkout (using braintree) the link is to the magento patch for this, this change stops the patch being overwritten. Im not sure if this is needed on the shipping-information file as well, but i dont seem to get any issues without it.
I dont know if this will be usefull for anyone else, or if it should be merged in, but if you could look it over and see if its usefull
cheers