When a full commit SHA is provided as revision, provide it with the git clone command and honor the depth #1880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1874
When providing a commit sha as revision of a Git source, then we always performed a
git clone --no-checkout
followed by agit checkout COMMIT_SHA
. By doing that, we performed a full history clone and therefore ignored thedepth
provided by the user.In case the commit sha is a full commit sha, we can actually provide it with
git clone --revision COMMIT_SHA
and then also honor the deptch. For a short commit sha, this is not working, there we must still clone the full history to be able to checkout the short sha afterwards.However, our ubi9-based images do not contain a Git binary that is new enough to support the
--revision
flag:Therefore, that optimized approach is only used when
--revision
is available.The existing unit tests cover both cases (full and short sha) already.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes