Skip to content

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Jul 1, 2025

Changes

Set field ownership for the Build and BuildRun controllers so that we avoid collisions when making API create/update calls (and future server-side apply calls).

/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Build and BuildRun controllers will use an explicit field owner when creating and updating their respective resources.

Set field ownership for the Build and BuildRun controllers so that
we avoid collisions when making API create/update calls (and future
server-side apply calls).

Assisted-by: Cursor
Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jul 1, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2025
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 1, 2025
@adambkaplan adambkaplan added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 1, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.17.0 milestone Jul 3, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0039876 into shipwright-io:main Jul 3, 2025
38 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants