Skip to content

Conversation

R3hankhan123
Copy link
Contributor

@R3hankhan123 R3hankhan123 commented Jul 8, 2025

Changes

.ko.yaml: Changed defaultBaseImage from ubi9/ubi-minimal to ubi10/ubi-minimal, and updated baseImageOverrides to use ubi10 tags for all components (bundle, git, image-processing, and waiter).

Fixes #1903

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has beenThis pull request updates the .ko.yaml file to use a newer base image (ubi10) and adjusts the image overrides accordingly to ensure compatibility.

Release Notes

All Shipwright container images are now built with Redhat Universal Base Image 10 as a base, was version 9 before

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jul 8, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2025
@openshift-ci openshift-ci bot requested review from dorzel and karanibm6 July 8, 2025 12:05
@qu1queee qu1queee requested review from SaschaSchwarze0 and qu1queee and removed request for dorzel and karanibm6 July 8, 2025 12:18
@adambkaplan
Copy link
Member

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 8, 2025
@adambkaplan adambkaplan added this to the release-v0.17.0 milestone Jul 8, 2025
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

A potential concern is backwards compatibility of the container with the underlying host kernel. According to Red Hat's container support matrix, they only support UBI 10 on RHEL 9 and 10 hosts. This corresponds to OpenShift/OKD versions 4.14 and higher (k8s 1.27+) - source (requires Red Hat account).

From a community perspective this change is fine, as we don't support k8s 1.27 any more.

Copy link
Contributor

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 824d498 into shipwright-io:main Jul 9, 2025
16 checks passed
@R3hankhan123 R3hankhan123 deleted the ubi10-controller branch July 10, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Build ubi10 base images and rebase shipwright images on top of those
3 participants