Fix go module files #461
Merged
Fix go module files #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go.mod does not have a proper indentation for the require() block. The go.mod was missing the changes introduced for the k8s.io/utils, this were already added in the vendor and the vendor/modules.txt before. The go.sum was not reflecting all changes. I detected the above by a simple `go mod tidy`.
qu1queee
requested review from
zhangtbj
and removed request for
otaviof and
adambkaplan
adambkaplan
approved these changes
Nov 2, 2020
openshift-ci-robot
added
lgtm
|
/lgtm cancel since @qu1queee asked for an additional review. |
openshift-ci-robot
removed
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go.mod does not have a proper indentation for the require() block.
The go.mod was missing the changes introduced for the k8s.io/utils, this
were already added in the vendor and the vendor/modules.txt before.
The go.sum was not reflecting all changes.
I detected the above by a simple
go mod tidy.