Skip to content

Refactor git samples #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Mar 2, 2021

Changes

Note: Im adding a WIP label for now, just to get first some feedback on these changes.

This covers around 80% of #366

This PR does the following:

Commits can be squashed, let me know.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Make use of shipwright assets instead of random repositories.

@openshift-ci-robot openshift-ci-robot added the release-note Label for when a PR has specified a release note label Mar 2, 2021
@qu1queee qu1queee added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@qu1queee qu1queee added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@qu1queee qu1queee mentioned this pull request Mar 2, 2021
@qu1queee qu1queee added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 2, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@qu1queee qu1queee added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@qu1queee qu1queee force-pushed the qu1queee/refactor_sample_endpoints branch from c17abfe to 0129e2d Compare March 3, 2021 12:49
@qu1queee qu1queee force-pushed the qu1queee/refactor_sample_endpoints branch from 0129e2d to af5d730 Compare March 3, 2021 13:08
@qu1queee qu1queee force-pushed the qu1queee/refactor_sample_endpoints branch from af5d730 to 33d4ba4 Compare March 4, 2021 10:00
@qu1queee qu1queee requested a review from SaschaSchwarze0 March 4, 2021 10:01
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021
@qu1queee qu1queee requested a review from zhangtbj March 4, 2021 10:25
@qu1queee qu1queee force-pushed the qu1queee/refactor_sample_endpoints branch from e64f2f0 to 9601559 Compare March 4, 2021 11:15
Copy link
Contributor

@zhangtbj zhangtbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit bf507cf into shipwright-io:master Mar 9, 2021
@qu1queee qu1queee deleted the qu1queee/refactor_sample_endpoints branch March 9, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants