Fix Shipwright CLI output message when incorrect flag is passed #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Fixes shipwright-io#346 # Changes: - Discard any messages or error written to stdio or stderr by goflag library. Return the error only. - In case of error while parsing the goflags, print the error, then print the CLI help and then exit with 1. Signed-off-by: Sayan Biswas <[email protected]>
sayan-biswas
force-pushed
the
fix-help-version
branch
from
1f65bed to
9427167
Compare
|
/cc @adambkaplan |
avinal
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Works as expected.
Test output:
➜ shp-cli git:(fix-help-version) ./shp --version
ERROR: flag provided but not defined: -version
Command-line client for Shipwright's Build API.
Usage:
shp [command] [resource] [flags]
shp [command]
Available Commands:
build Manage Builds
buildrun Manage BuildRuns
buildstrategy Manage namespaced BuildStrategies
clusterbuildstrategy Manage cluster-scoped BuildStrategies
version version
Flags:
--kubeconfig string Path to the kubeconfig file to use for CLI requests.
-n, --namespace string If present, the namespace scope for this CLI request
--request-timeout string The length of time to wait before giving up on a single server request. Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't timeout requests. (default "0")
Use "shp [command] --help" for more information about a command.
adambkaplan
approved these changes
Sep 5, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #346
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes