Upgrade operator-sdk to 1.17.0 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/cleanup
adambkaplan
force-pushed
the
upgrade-osdk-1.17.0
branch
from
871a0ee to
824c8ed
Compare
openshift-ci
bot
added
the
needs-rebase
- Update k8s to v1.23.0 - Update controller-runtime to v0.11.0 - Update ginkgo to v1.16.5 - Update gomega to v1.17.0 - Update manifestival to v0.7.1 Per upgrade instructions in https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.17.0/
- Add target to set up envtest with latest version. Remove script to test with envtest. - Use cancellable context when running tests. This fixes an issue that causes the kube-apiserver process to hang during teardown.
- Update Makefile so it conforms to newer defaults for operator-sdk and controller-runtime. - Upgrade controller-gen to v0.8.0 - Upgrade opm to v1.19.1 - Upgrade operator-sdk to v1.17.0 - Regenerate manifests and bundle
Assign resource requests and limits to the kube-rbac-proxy sidecar, per upgrade instructions. See https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.17.0/
Add the kubectl default container annotation to the operator deployment, per the upgrade instructions for v1.16.0. See https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.16.0/#add-annotation-to-specify-the-default-container
adambkaplan
force-pushed
the
upgrade-osdk-1.17.0
branch
from
824c8ed to
dfd8d63
Compare
openshift-ci
bot
removed
the
needs-rebase
otaviof
reviewed
Mar 15, 2022
| @@ -6,7 +6,7 @@ LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/ | |||
| LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/ | |||
| LABEL operators.operatorframework.io.bundle.package.v1=shipwright-operator | |||
| LABEL operators.operatorframework.io.bundle.channels.v1=alpha | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.13.0+git | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0+git | |||
There was a problem hiding this comment.
The PR title says 1.17.0, but I only see references to 1.16.0 instead.
There was a problem hiding this comment.
Yeah, this seems to be a bug in operator-sdk. The version of the label and the sdk version are always off by 1.
|
LGTM aside from @otaviof 's question at #59 (comment) if there is an explanation for that @adambkaplan go ahead and post a comment in that thread; otherwise, it does seem like it should be consistent and go to 17 instead of 16 |
|
Filed operator-framework/operator-sdk#5612 to report the semantic version issue. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade to operator-sdk v1.17.0, along with dependencies for controller-runtime and kubernetes:
Fixes #56
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes