Skip to content

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Mar 11, 2025

Changes

Remove the docsy theme submodule. This has been replaced by Hugo's module system, which requires the golang SDK to be installed on the writer's computer.

Also update the build dependencies in our Netlify environment.

Fixes #158

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

action required: Removed git submodule with Docsy theme. This has been replaced by Hugo's module system.

Remove the docsy theme submodule. This has been replaced by Hugo's
module system, which requires the golang SDK to be installed on the
writer's computer.

Fixes shipwright-io#158

Signed-off-by: Adam Kaplan <[email protected]>
Set the following versions for build dependencies:

- Hugo: v0.145.0
- NodeJS: v22.y
- Golang: 1.23.4

Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 11, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 719bc7d into shipwright-io:main Apr 9, 2025
7 checks passed
@adambkaplan adambkaplan linked an issue Aug 21, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG][docs] Access Docsy as a Hugo module or Git submodule, not both [BUG] Website uses outdated dependencies
2 participants