Skip to content

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented May 20, 2025

Changes

Restore the content in the "Intro to Shipwright Part 1" blog post. This was somehow lost in the move to LotusDocs.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Restore content of the Intro to Shipwright blog post (part 1).

Restore the content in the "Intro to Shipwright Part 1" blog post. This
was somehow lost in the move to LotusDocs.

Signed-off-by: Adam Kaplan <[email protected]>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2025
@adambkaplan adambkaplan added kind/bug Categorizes issue or PR as related to a bug. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
Copy link
Contributor

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@rxinui
Copy link
Contributor

rxinui commented May 21, 2025

The missing piece I was looking for! Thank you @adambkaplan

If I find any other issue, I will just go ahead and raise a Issue+PR to help out. Currently reviewing the whole content

@openshift-merge-bot openshift-merge-bot bot merged commit 6f6de6b into shipwright-io:main May 22, 2025
7 checks passed
@adambkaplan adambkaplan deleted the fix-old-blog branch May 22, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants