-
Notifications
You must be signed in to change notification settings - Fork 29
Blog post for build scheduler features #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Excellent blog post! The only hard requirement blocking publication is the draft: true
flag in the post metadata. All of my other comments are minor grammar/style nits that shouldn't blog LGTM/merge.
--- | ||
title: "Shipwright build scheduler features" | ||
date: 2025-05-20T11:39:00-06:00 | ||
draft: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to false
so it renders in the deploy preview:
draft: true | |
draft: false |
|
||
## New Build Scheduler Features | ||
|
||
A new set of build scheduling features introduced in [v0.15](https://shipwright.io/docs/blog/posts/2025-02-28-release-v0.15) have recently been merged into Shipwright that allows users to specify node selectors, custom schedulers, and tolerations for builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit to clarify that this isn't exactly recent:
A new set of build scheduling features introduced in [v0.15](https://shipwright.io/docs/blog/posts/2025-02-28-release-v0.15) have recently been merged into Shipwright that allows users to specify node selectors, custom schedulers, and tolerations for builds. | |
A new set of build scheduling features introduced in [v0.15](https://shipwright.io/docs/blog/posts/2025-02-28-release-v0.15) allows users to specify node selectors, custom schedulers, and tolerations for builds. |
|
||
A new set of build scheduling features introduced in [v0.15](https://shipwright.io/docs/blog/posts/2025-02-28-release-v0.15) have recently been merged into Shipwright that allows users to specify node selectors, custom schedulers, and tolerations for builds. | ||
|
||
These make it easier to schedule builds when using Shipwright on clusters with nodes of multiple architectures, use a scheduler that is tuned to a certain workflow, or just more general control of which nodes builds get scheduled on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - we can assume "when using Shipwright", and fix repeated words:
These make it easier to schedule builds when using Shipwright on clusters with nodes of multiple architectures, use a scheduler that is tuned to a certain workflow, or just more general control of which nodes builds get scheduled on. | |
These make it easier to schedule builds on clusters with nodes of multiple CPU architectures, use a scheduler that is tuned to a certain workflow, or just more general control of which nodes builds run on. |
Instead of specifying these options when running the build, we can also specify them when creating the build: | ||
|
||
```bash | ||
$ shp build create test-golang-build --output-image=kind.local/test/test-golang-build --source-git-url=https://github.com/shipwright-io/sample-go --source-context-dir=docker-build --strategy-name=buildah-shipwright-managed-push --scheduler-name=test-scheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - use newlines since we have so many flags:
$ shp build create test-golang-build --output-image=kind.local/test/test-golang-build --source-git-url=https://github.com/shipwright-io/sample-go --source-context-dir=docker-build --strategy-name=buildah-shipwright-managed-push --scheduler-name=test-scheduler | |
$ shp build create test-golang-build \ | |
--output-image=kind.local/test/test-golang-build \ | |
--source-git-url=https://github.com/shipwright-io/sample-go \ | |
--source-context-dir=docker-build \ | |
--strategy-name=buildah-shipwright-managed-push \ | |
--scheduler-name=test-scheduler |
We'll start with the same example build as above: | ||
|
||
```bash | ||
$ shp build create test-golang-build --output-image=kind.local/test/test-golang-build --source-git-url=https://github.com/shipwright-io/sample-go --source-context-dir=docker-build --strategy-name=buildah-shipwright-managed-push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - ditto on newlines:
$ shp build create test-golang-build --output-image=kind.local/test/test-golang-build --source-git-url=https://github.com/shipwright-io/sample-go --source-context-dir=docker-build --strategy-name=buildah-shipwright-managed-push | |
$ shp build create test-golang-build \ | |
--output-image=kind.local/test/test-golang-build \ | |
--source-git-url=https://github.com/shipwright-io/sample-go \ | |
--source-context-dir=docker-build \ | |
--strategy-name=buildah-shipwright-managed-push |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dylan Orzel <[email protected]>
@adambkaplan thanks for the review! Addressed everything above. |
/lgtm Looks great! Thanks so much! |
Changes
Add a blog post about the build scheduling features as part of shipwright-io/community#213
Fixes #121
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes