refactor: add migration logging optional fields #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskemper
changed the title
larskemper
force-pushed
the
refactor/migration-logging-optional-fields
branch
from
6f7d36f to
5f11375
Compare
larskemper
force-pushed
the
refactor/migration-logging-optional-fields
branch
from
0adfed7 to
c76e78e
Compare
larskemper
requested review from
CR0YD,
MalteJanz,
Copilot,
ennasus4sun and
jozsefdamokos
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the migration logging system by adding optional fields to migration log entries, implementing a builder pattern for log creation, and modernizing the logging architecture.
Key changes:
- Added optional fields (entity name, field info, source/converted data, exception details) to migration logging
- Introduced
SwagMigrationLogBuilderfor constructing log entries with optional data - Replaced constructor-based log instantiation with builder pattern across all converters and services
Reviewed Changes
Copilot reviewed 94 out of 96 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Migration/Logging/Log/Builder/SwagMigrationLogBuilder.php |
New builder class for constructing migration log entries with optional fields |
src/Migration/Logging/Log/Builder/AbstractSwagMigrationLogEntry.php |
New abstract base class implementing common log entry functionality |
src/Migration/Logging/SwagMigrationLoggingDefinition.php |
Added new optional database fields for enhanced logging data |
| Multiple converter files | Updated to use builder pattern instead of direct constructor calls |
| Test files | Updated test expectations to match new logging structure |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/Profile/Shopware/Converter/MainVariantRelationConverter.php
Outdated
Show resolved
Hide resolved
larskemper
merged commit d2468fd
into
feature/migration-logging-refactor
7 checks passed
| */ | ||
| public function build(string $logClass): AbstractSwagMigrationLogEntry | ||
| { | ||
| $log = new $logClass( |
Member
There was a problem hiding this comment.
If the $logClass is invalid class name or the constructor arguments dont match it will throw an error. So I think we need a try ... catch here.
larskemper
added a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11811