-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add migration validation of converted data #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration validation of converted data #51
Conversation
|
LGTM so far |
ennasus4sun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, too.
just one thought:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements migration validation of converted data to ensure data integrity during migration processes. It introduces comprehensive validation logic that checks entity structure, field values, and foreign key relationships.
- Validates missing required fields, unexpected fields, and field value constraints
- Validates foreign key mappings to ensure referential integrity
- Provides extensible event-driven validation framework with pre/post validation events
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Migration/Validation/SwagMigrationValidationService.php |
Core validation service implementing structure, field, and association validation logic |
src/Migration/Validation/SwagMigrationValidationContext.php |
Context object holding validation state and converted data |
src/Migration/Validation/SwagMigrationValidationResult.php |
Result container for validation logs and entity information |
src/Migration/Validation/Log/ |
Validation-specific log classes for different error types |
src/Migration/Validation/Event/ |
Pre and post validation events for extensibility |
src/Migration/Service/MigrationDataConverter.php |
Integration of validation service into data conversion process |
src/Migration/Mapping/MappingService.php |
Added foreign key validation method |
tests/ |
Comprehensive test coverage for all validation components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f69773c
into
feature/migration-logging-refactor
resolves #11813
covered validation: