Skip to content

Conversation

@larskemper
Copy link
Member

@larskemper larskemper commented Sep 4, 2025

resolves #11813

covered validation:

  • missing required fields
  • unexpected fields
  • validation of field value
  • lookup of foreign key mapping

@larskemper larskemper requested a review from Copilot September 4, 2025 09:32
@larskemper larskemper self-assigned this Sep 4, 2025
@larskemper larskemper marked this pull request as ready for review September 4, 2025 09:43
@larskemper larskemper changed the title feat: add migration validation of converted data poc: add migration validation of converted data Sep 4, 2025

This comment was marked as outdated.

@jozsefdamokos
Copy link
Member

LGTM so far

Copy link
Contributor

@ennasus4sun ennasus4sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, too.
just one thought:

@larskemper larskemper changed the title poc: add migration validation of converted data feat: add migration validation of converted data Sep 4, 2025
@larskemper larskemper requested a review from Copilot September 4, 2025 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements migration validation of converted data to ensure data integrity during migration processes. It introduces comprehensive validation logic that checks entity structure, field values, and foreign key relationships.

  • Validates missing required fields, unexpected fields, and field value constraints
  • Validates foreign key mappings to ensure referential integrity
  • Provides extensible event-driven validation framework with pre/post validation events

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Migration/Validation/SwagMigrationValidationService.php Core validation service implementing structure, field, and association validation logic
src/Migration/Validation/SwagMigrationValidationContext.php Context object holding validation state and converted data
src/Migration/Validation/SwagMigrationValidationResult.php Result container for validation logs and entity information
src/Migration/Validation/Log/ Validation-specific log classes for different error types
src/Migration/Validation/Event/ Pre and post validation events for extensibility
src/Migration/Service/MigrationDataConverter.php Integration of validation service into data conversion process
src/Migration/Mapping/MappingService.php Added foreign key validation method
tests/ Comprehensive test coverage for all validation components

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larskemper larskemper merged commit f69773c into feature/migration-logging-refactor Sep 17, 2025
7 checks passed
@larskemper larskemper deleted the feat/validate-converted-data branch September 17, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants