Skip to content

Conversation

@larskemper
Copy link
Member

@larskemper larskemper commented Sep 18, 2025

resolves #10820

@larskemper larskemper requested a review from Copilot September 18, 2025 11:31
@larskemper larskemper self-assigned this Sep 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new asynchronous checksum reset feature using the message queue system and provides enhanced UI feedback for migration operations.

  • Adds asynchronous checksum reset processing via message queue
  • Implements UI state management for checksum reset operations
  • Adds API endpoint for monitoring message queue status

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
RunService.php Converts synchronous checksum reset to async message queue dispatch
ResetChecksumMessage.php New message queue message for checksum reset operations
ResetChecksumHandler.php Message handler for batch processing checksum resets
migration.store.ts Adds state management for checksum reset UI feedback
swag-migration-shop-information/* UI components for displaying reset progress
StatusController.php Adds API endpoint for message queue monitoring
Various test files Removes dependency on SwagMigrationDataDefinition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch from 898dd83 to 93c4843 Compare September 19, 2025 11:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larskemper
Copy link
Member Author

larskemper commented Sep 19, 2025

@MalteJanz / @shopware/st-runtime-terror , what are your thoughts on the current state?

@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch 2 times, most recently from 7834227 to 5316dbf Compare September 19, 2025 12:06
Copy link
Contributor

@ennasus4sun ennasus4sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far.

@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch from 5316dbf to 5078cd4 Compare October 2, 2025 13:49
@larskemper larskemper marked this pull request as ready for review October 27, 2025 10:42
@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch from 5078cd4 to 556fced Compare October 27, 2025 12:05
@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch from 556fced to 58c3a00 Compare October 27, 2025 12:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/Resources/app/administration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts:1

  • The onCloseResetModal method refreshes the connection before closing the modal, but if onClickRefreshConnection() throws an error, the modal will remain open. Consider wrapping this in a try-finally block to ensure the modal closes even if the refresh fails.
import template from './swag-migration-shop-information.html.twig';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@larskemper larskemper marked this pull request as draft October 28, 2025 07:38
@larskemper larskemper requested a review from Copilot October 28, 2025 09:52
@larskemper larskemper marked this pull request as ready for review October 28, 2025 09:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@larskemper larskemper force-pushed the feat/checksum-and-reset-via-mq branch from 9750e4a to f0caf03 Compare October 29, 2025 12:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@larskemper larskemper merged commit 5be00ca into feature/migration-logging-refactor Oct 29, 2025
9 of 10 checks passed
@larskemper larskemper deleted the feat/checksum-and-reset-via-mq branch October 29, 2025 14:31
larskemper added a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants