-
Notifications
You must be signed in to change notification settings - Fork 25
feat: checksum and reset via mq #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: checksum and reset via mq #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new asynchronous checksum reset feature using the message queue system and provides enhanced UI feedback for migration operations.
- Adds asynchronous checksum reset processing via message queue
- Implements UI state management for checksum reset operations
- Adds API endpoint for monitoring message queue status
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RunService.php | Converts synchronous checksum reset to async message queue dispatch |
| ResetChecksumMessage.php | New message queue message for checksum reset operations |
| ResetChecksumHandler.php | Message handler for batch processing checksum resets |
| migration.store.ts | Adds state management for checksum reset UI feedback |
| swag-migration-shop-information/* | UI components for displaying reset progress |
| StatusController.php | Adds API endpoint for message queue monitoring |
| Various test files | Removes dependency on SwagMigrationDataDefinition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ion/component/card/swag-migration-shop-information/swag-migration-shop-information.html.twig
Outdated
Show resolved
Hide resolved
src/Resources/app/administration/src/core/service/api/swag-migration.api.service.ts
Outdated
Show resolved
Hide resolved
...nistration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts
Outdated
Show resolved
Hide resolved
src/Migration/MessageQueue/Handler/Processor/AbortingProcessor.php
Outdated
Show resolved
Hide resolved
898dd83 to
93c4843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Resources/app/administration/src/core/service/api/swag-migration.api.service.ts
Outdated
Show resolved
Hide resolved
src/Migration/MessageQueue/Handler/Processor/CleanUpProcessor.php
Outdated
Show resolved
Hide resolved
...nistration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts
Outdated
Show resolved
Hide resolved
|
@MalteJanz / @shopware/st-runtime-terror , what are your thoughts on the current state? |
7834227 to
5316dbf
Compare
ennasus4sun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
...nistration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts
Outdated
Show resolved
Hide resolved
5316dbf to
5078cd4
Compare
5078cd4 to
556fced
Compare
556fced to
58c3a00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/Resources/app/administration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts:1
- The
onCloseResetModalmethod refreshes the connection before closing the modal, but ifonClickRefreshConnection()throws an error, the modal will remain open. Consider wrapping this in a try-finally block to ensure the modal closes even if the refresh fails.
import template from './swag-migration-shop-information.html.twig';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Resources/app/administration/src/module/swag-migration/snippet/en-GB.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Migration/MessageQueue/Handler/Processor/CleanUpProcessor.php
Outdated
Show resolved
Hide resolved
...nistration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts
Outdated
Show resolved
Hide resolved
src/Core/Migration/Migration1759000000AddIsResettingChecksumsToSetting.php
Outdated
Show resolved
Hide resolved
src/Migration/MessageQueue/Handler/Processor/CleanUpProcessor.php
Outdated
Show resolved
Hide resolved
9750e4a to
f0caf03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5be00ca
into
feature/migration-logging-refactor
resolves #10820