Skip to content

Conversation

@larskemper
Copy link
Member

resolves #12584

@larskemper larskemper requested a review from Copilot September 22, 2025 09:43
@larskemper larskemper self-assigned this Sep 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SwagMigrationAssistant module to use Meteor design token variables instead of hardcoded values and legacy SCSS variables, improving design system consistency. The changes also include UI improvements and some component cleanup.

  • Replace hardcoded font sizes, colors, and spacing with Meteor design token CSS variables
  • Update stylelint configuration to enforce Meteor token usage as errors instead of warnings
  • Add missing translation strings and improve empty state presentations

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Resources/app/administration/stylelint.config.mjs Updates Meteor token rules from warnings to errors
src/Resources/app/administration/src/module/swag-migration/snippet/*.json Adds new translation strings for empty states
src/Resources/app/administration/src/module/swag-migration/page/**/*.scss Converts legacy SCSS variables to Meteor design tokens for colors, fonts, and spacing
src/Resources/app/administration/src/module/swag-migration/component/**/*.scss Replaces hardcoded values with Meteor token variables
src/Resources/app/administration/src/module/swag-migration/component/swag-migration-expand-div/ Removes unused expand div component
.gitlab/ Removes GitLab CI configuration files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larskemper larskemper marked this pull request as ready for review September 22, 2025 09:47
@larskemper larskemper marked this pull request as draft September 22, 2025 09:49
@larskemper larskemper force-pushed the refactor/use-meteor-tokens branch from cb44512 to e2acdb6 Compare September 22, 2025 11:41
@larskemper larskemper marked this pull request as ready for review September 22, 2025 11:45
@larskemper larskemper merged commit 976d4b4 into feature/migration-logging-refactor Sep 23, 2025
8 checks passed
@larskemper larskemper deleted the refactor/use-meteor-tokens branch September 23, 2025 09:37
larskemper added a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants