feat: apply fixes prototype #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
DennisGarding
requested review from
CR0YD,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
Member
|
@DennisGarding I dont really understand how this should work. Can you give an example of how this would be called? |
ennasus4sun
reviewed
Oct 6, 2025
Contributor
Author
|
We can apply the fixes before we write. Just an example. We need to figure out the best position for this, because we need the connectionId 
|
ennasus4sun
approved these changes
Oct 9, 2025
MalteJanz
requested changes
Oct 14, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
Open questions from my side that I think this prototype should answer:
- Get it implemented in an actual data migration, e.g. you mentioned the
AbstractWriteras a place to put this new logic, try to get it working there - Intentionally break some data in your source system (e.g. remove the email of one customer in SW5). Then migrate them to SW6. You should find a log entry about it and the customer shouldn't be migrated. Then manually add a fix to
swag_migration_fixesand migrate again. Is the customer then migrated properly? - After 2. fix the SW5 customer in the source system (assign him a different email than used in the fix). Then migrate again. Takes the new source data or the old fix priority?
Contributor
|
would be great if you could add a proper PR description that documents your insights and decisions from this prototype and also answers these questions 🙂 : |
MalteJanz
reviewed
Oct 23, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
LGTM for the prototype, nice job 👍
…are/SwagMigrationAssistant into 12365/apply-fixes-prototype
MalteJanz
approved these changes
Oct 28, 2025
…are/SwagMigrationAssistant into 12365/apply-fixes-prototype
DennisGarding
merged commit 35709d7
into
feature/migration-logging-refactor
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #12365
Implement apply migration fix before write the converted data to DB
Answered Questions:
Works now: see src/Migration/Service/MigrationDataWriter.php line 106 - 107
Works fine and the customer is migrated.
Currently, there is no functionality to prioritize the source data. The fix is always applied. There is a Ticket to implement this! See Ticket: shopware/shopware#11819