fix: adjust log file generation #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the migration log file generation by restructuring the log format, adding detailed log entry information, and enhancing the overall readability of the generated logs.
Key changes:
- Refactored log generation to include comprehensive log entry details with proper formatting
- Restructured log file format with clear section headers and improved information organization
- Updated time format and made constants public for test accessibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Migration/History/HistoryService.php | Enhanced log generation with detailed entry printing, restructured format sections, and improved error handling |
| tests/unit/Migration/History/HistoryServiceTest.php | Added comprehensive test coverage for the new log generation functionality with various test scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
larskemper
force-pushed
the
fix/adjust-log-files
branch
from
1d1163c to
5b50163
Compare
larskemper
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
jozsefdamokos
approved these changes
Oct 1, 2025
larskemper
merged commit fc4372d
into
feature/migration-logging-refactor
7 checks passed
larskemper
added a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11816
example migration log:
migration-log-example.txt