feat: split message queue process #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozsefdamokos
changed the title
jozsefdamokos
force-pushed
the
feat/split-message-queue-for-fixes
branch
from
6a262bd to
b7b7322
Compare
jozsefdamokos
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
larskemper and
vintagesucks
MalteJanz
reviewed
Oct 17, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
Nice work 💪 , looks mostly good to me, I only added some smaller comments 🙂
src/Resources/app/administration/src/module/swag-migration/snippet/de-DE.json
Outdated
Show resolved
Hide resolved
src/Resources/app/administration/src/module/swag-migration/snippet/de-DE.json
Outdated
Show resolved
Hide resolved
MalteJanz
approved these changes
Oct 23, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
LGTM 👍 , only found two more smaller things
...ion/component/loading-screen/swag-migration-apply-fixes/swag-migration-apply-fixes.html.twig
Outdated
Show resolved
Hide resolved
larskemper
approved these changes
Oct 27, 2025
MalteJanz
approved these changes
Oct 28, 2025
DennisGarding
approved these changes
Oct 29, 2025
…sage-queue-for-fixes
…are/SwagMigrationAssistant into feat/split-message-queue-for-fixes
…sage-queue-for-fixes # Conflicts: # src/Controller/StatusController.php # src/Migration/Run/RunServiceInterface.php # tests/Migration/Controller/StatusControllerTest.php
larskemper
approved these changes
Oct 31, 2025
jozsefdamokos
force-pushed
the
feat/split-message-queue-for-fixes
branch
from
4b40778 to
8de6527
Compare
jozsefdamokos
force-pushed
the
feat/split-message-queue-for-fixes
branch
from
8de6527 to
3c87c5f
Compare
…sage-queue-for-fixes # Conflicts: # src/Exception/MigrationException.php
jozsefdamokos
merged commit 63dbef2
into
feature/migration-logging-refactor
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11817