feat: add acl constraints #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements ACL (Access Control List) constraints for the Migration Assistant feature, replacing generic 'admin' permissions with granular role-based access control.
Key changes:
- Introduced a comprehensive ACL system with four roles: viewer, editor, creator, and deleter
- Updated all API route permissions from 'admin' to specific migration permissions
- Added permission checks in UI components to disable actions based on user roles
Reviewed Changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Resources/app/administration/src/module/swag-migration/acl/index.ts | Defines ACL structure with viewer, editor, creator, and deleter roles |
| src/Resources/app/administration/src/module/swag-migration/index.ts | Updates route privileges and imports ACL configuration |
| src/Controller/StatusController.php | Replaces 'admin' ACL with migration-specific permissions |
| src/Controller/PremappingController.php | Updates premapping endpoints to require editor permission |
| src/Controller/HistoryController.php | Updates history endpoints with appropriate migration permissions |
| src/Controller/DataProviderController.php | Updates data provider endpoints with viewer/editor permissions |
| src/Resources/app/administration/src/module/swag-migration/store/migration.store.ts | Adds ACL checks to store actions |
| src/Resources/app/administration/src/module/swag-migration/snippet/en-GB.json | Adds permission-related translation strings |
| src/Resources/app/administration/src/module/swag-migration/snippet/de-DE.json | Adds German translations for permissions |
| src/Resources/app/administration/src/module/swag-migration/page/swag-migration-process-screen/index.ts | Injects ACL service and adds permission check |
| src/Resources/app/administration/src/module/swag-migration/page/swag-migration-index/index.ts | Injects ACL service |
| src/Resources/app/administration/src/module/swag-migration/page/swag-migration-history/index.ts | Injects ACL service |
| src/Resources/app/administration/src/module/swag-migration/component/card/swag-migration-shop-information/index.ts | Injects ACL service |
| src/Resources/app/administration/src/module/swag-migration/extension/sw-dashboard-index/index.ts | Replaces isAdmin check with viewer permission |
| tests/Jest/package.json | Reorganizes dependencies alphabetically and adds TypeScript |
| src/Resources/app/administration/package.json | Reorganizes dependencies and adds meteor-tokens |
Files not reviewed (2)
- tests/Jest/package-lock.json: Language not supported
- tests/acceptance/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ion/component/card/swag-migration-shop-information/swag-migration-shop-information.html.twig
Outdated
Show resolved
Hide resolved
larskemper
force-pushed
the
feat/add-acl-constrains
branch
3 times, most recently
from
cd9b013 to
a6eb3da
Compare
larskemper
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
larskemper
force-pushed
the
feat/add-acl-constrains
branch
from
a6eb3da to
0bcc699
Compare
MalteJanz
reviewed
Oct 28, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
Just had a rough first look 🙂
src/Resources/app/administration/src/module/swag-migration/acl/index.ts
Outdated
Show resolved
Hide resolved
larskemper
force-pushed
the
feat/add-acl-constrains
branch
2 times, most recently
from
107db7f to
ae86cfa
Compare
larskemper
force-pushed
the
feat/add-acl-constrains
branch
from
ae86cfa to
2287d30
Compare
…or' into feat/add-acl-constrains
MalteJanz
approved these changes
Nov 3, 2025
jozsefdamokos
approved these changes
Nov 3, 2025
larskemper
merged commit 7ce1a74
into
feature/migration-logging-refactor
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13017
Introduced ACL migration roles (viewer, editor, creator, deleter) to make migration access configurable. Previously, access to any migration UI or API route was restricted and available only to admin users.