-
Notifications
You must be signed in to change notification settings - Fork 25
Chore: 13247/change table swag migration logging #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DennisGarding
merged 24 commits into
feature/migration-logging-refactor
from
13247/change-table-swagMigrationLogging
Nov 7, 2025
Merged
Chore: 13247/change table swag migration logging #80
DennisGarding
merged 24 commits into
feature/migration-logging-refactor
from
13247/change-table-swagMigrationLogging
Nov 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
…are/SwagMigrationAssistant into feature/migration-logging-refactor
…are/SwagMigrationAssistant into 13247/change-table-swagMigrationLogging
MalteJanz
reviewed
Nov 3, 2025
src/Core/Migration/Migration1761903189AdjustSwagMigrationLoggingTable.php
Outdated
Show resolved
Hide resolved
src/Core/Migration/Migration1761903189AdjustSwagMigrationLoggingTable.php
Outdated
Show resolved
Hide resolved
larskemper
approved these changes
Nov 3, 2025
MalteJanz
requested changes
Nov 3, 2025
Contributor
MalteJanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these already all places where logs are created? I guess any logs that are created in converters are being covered by your other PR then? #79
MalteJanz
reviewed
Nov 4, 2025
MalteJanz
reviewed
Nov 4, 2025
MalteJanz
reviewed
Nov 4, 2025
MalteJanz
reviewed
Nov 4, 2025
MalteJanz
reviewed
Nov 4, 2025
MalteJanz
reviewed
Nov 4, 2025
…are/SwagMigrationAssistant into 13247/change-table-swagMigrationLogging
MalteJanz
approved these changes
Nov 6, 2025
src/Core/Migration/Migration1754897550AddFieldsToMigrationLogs.php
Outdated
Show resolved
Hide resolved
src/Core/Migration/Migration1754897550AddFieldsToMigrationLogs.php
Outdated
Show resolved
Hide resolved
larskemper
reviewed
Nov 6, 2025
8a16844
into
feature/migration-logging-refactor
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #80