refactor: re-group migrations #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates database migrations by removing three separate migration files and their tests, and instead incorporating their changes directly into the base migration files.
- Removes
main_mapping_idcolumn and foreign key from theswag_migration_fixtable - Adds
entity_idindex to bothswag_migration_fixandswag_migration_loggingtables - Replaces
used_mappingfield withentity_idfield in the logging table schema
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/Migration/Migration1757598733AddMigrationFixesTable.php | Removes main_mapping_id field and its foreign key constraint; adds entity_id index to the table creation |
| src/Core/Migration/Migration1754897550AddFieldsToMigrationLogs.php | Adds entity_id field to OPTIONAL_FIELDS, removes used_mapping field, and adds index creation for entity_id |
| src/Core/Migration/Migration1762436233RemoveMainMappingIdFromMigrationFix.php | Migration file deleted - functionality consolidated into base migration |
| src/Core/Migration/Migration1762177450AddEntityIdAndEntityNameToFixTable.php | Migration file deleted - functionality consolidated into base migration |
| src/Core/Migration/Migration1761903189AdjustSwagMigrationLoggingTable.php | Migration file deleted - functionality consolidated into base migration |
| tests/Core/Migration/Migration1762436233RemoveMainMappingIdFromMigrationFixTest.php | Test file deleted along with migration consolidation |
| tests/Core/Migration/Migration1762177450AddEntityIdAndEntityNameToFixTableTest.php | Test file deleted along with migration consolidation |
| tests/Core/Migration/Migration1761903189AdjustSwagMigrationLoggingTableTest.php | Test file deleted along with migration consolidation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
larskemper
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
jozsefdamokos
approved these changes
Nov 10, 2025
larskemper
merged commit 6c36b6d
into
feature/migration-logging-refactor
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-group error resolution migrations & delete unnecessary migrations/code