chore: check naming consistency across error resolution #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskemper
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
ennasus4sun
approved these changes
Nov 27, 2025
MalteJanz
approved these changes
Nov 28, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
After my comments are resolved, it LGTM 👍
src/Migration/ErrorResolution/SwagMigrationErrorResolutionService.php
Outdated
Show resolved
Hide resolved
…or' into chore/check-naming-consistency-across-error-resolution
jozsefdamokos
approved these changes
Nov 28, 2025
MalteJanz
approved these changes
Nov 28, 2025
larskemper
merged commit 8f780ff
into
feature/migration-logging-refactor
11 checks passed
larskemper
deleted the
chore/check-naming-consistency-across-error-resolution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves shopware/shopware#13671
Changes:
after-sales=>fundamentals@after-salesMigrationFixservices =>ErrorResolutionservicesErrorResolutionapply-fixes=>error-resolutionSwagMigrationprefix to useMigrationprefix