-
Notifications
You must be signed in to change notification settings - Fork 25
chore: resolve merge conflicts #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
larskemper
wants to merge
7
commits into
feature/migration-logging-refactor
Choose a base branch
from
chore/resolve-merge-conflicts
base: feature/migration-logging-refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
887f7d8
feat: delay step transition until all media is processed (#72)
jozsefdamokos b0918be
docs: add pr template (#89)
larskemper 7697506
fix: support migrating email headers and footers (#87)
vintagesucks 1cf56ed
fix: dont migrate core.app.shopIdV2 (#91)
jozsefdamokos 699340c
fix: migrated document availability in frontend (#92)
DennisGarding 2145f9d
Merge remote-tracking branch 'origin/trunk' into chore/resolve-merge-…
larskemper effbfff
fix: merge conflicts
larskemper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ### 1. Why is this change necessary? | ||
|
|
||
| // Please link to the relevant issues, if they exists, or explain the solved issue here. e.g. | ||
| // closes https://github.com/shopware/shopware/issues/{ISSUE_NUMBER} | ||
|
|
||
| ### 2. What does this change do, exactly? | ||
|
|
||
| // Shortly explain how your change solves the issue | ||
| // If the issue has more than one obvious solution, | ||
| // shortly explain your reasoning for your chosen approach | ||
|
|
||
| ### 3. Describe each step to reproduce the issue or behaviour. | ||
|
|
||
|
|
||
| ### 5. Checklist | ||
|
|
||
| - [ ] I have created the PR in draft status and only open it when it's ready for review | ||
| - [ ] If the change is large: I have thought about splitting it up into smaller PRs | ||
| - [ ] I have written tests and if it's a bug fix verified that they fail without my change or that new code is covered by tests | ||
| - [ ] I have updated developer-facing release notes if this change affects external developers | ||
| - [ ] I have written or adjusted the documentation according to my changes | ||
| - [ ] I added the correct package annotation to each `src` file (not strictly necessary for tests) | ||
| - [ ] This change has code comments where appropriate, especially for non-obvious lines of code | ||
| - [ ] Ensure the pull request title as well as first commit follows conventional commits | ||
| - [ ] I have thought about well-defined extension points and marked everything else as `@internal` / `@private` | ||
Large diffs are not rendered by default.
Oops, something went wrong.
51 changes: 51 additions & 0 deletions
51
src/DataProvider/Provider/Data/MailHeaderFooterProvider.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?php declare(strict_types=1); | ||
| /* | ||
| * (c) shopware AG <[email protected]> | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace SwagMigrationAssistant\DataProvider\Provider\Data; | ||
|
|
||
| use Shopware\Core\Content\MailTemplate\Aggregate\MailHeaderFooter\MailHeaderFooterCollection; | ||
| use Shopware\Core\Framework\Context; | ||
| use Shopware\Core\Framework\DataAbstractionLayer\EntityRepository; | ||
| use Shopware\Core\Framework\DataAbstractionLayer\Search\Criteria; | ||
| use Shopware\Core\Framework\DataAbstractionLayer\Search\Sorting\FieldSorting; | ||
| use Shopware\Core\Framework\Log\Package; | ||
| use SwagMigrationAssistant\Migration\DataSelection\DefaultEntities; | ||
|
|
||
| #[Package('fundamentals@after-sales')] | ||
| class MailHeaderFooterProvider extends AbstractProvider | ||
| { | ||
| /** | ||
| * @param EntityRepository<MailHeaderFooterCollection> $mailHeaderFooterRepo | ||
| */ | ||
| public function __construct(private readonly EntityRepository $mailHeaderFooterRepo) | ||
| { | ||
| } | ||
|
|
||
| public function getIdentifier(): string | ||
| { | ||
| return DefaultEntities::MAIL_HEADER_FOOTER; | ||
| } | ||
|
|
||
| public function getProvidedData(int $limit, int $offset, Context $context): array | ||
| { | ||
| $criteria = new Criteria(); | ||
| $criteria->setLimit($limit); | ||
| $criteria->setOffset($offset); | ||
| $criteria->addAssociation('translations'); | ||
| $criteria->addSorting(new FieldSorting('id')); | ||
| $result = $this->mailHeaderFooterRepo->search($criteria, $context); | ||
|
|
||
| return $this->cleanupSearchResult($result, [ | ||
| 'mailHeaderFooterId', | ||
| ]); | ||
| } | ||
|
|
||
| public function getProvidedTotal(Context $context): int | ||
| { | ||
| return $this->readTotalFromRepo($this->mailHeaderFooterRepo, $context); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge!