-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add meaningful data to magento migration logs #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add meaningful data to magento migration logs #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Magento migration logging system by adding meaningful context data to log entries across multiple converter classes. The changes replace placeholder TODO comments with comprehensive logging information.
Key changes:
- Add contextual metadata to migration log builders including entity names, field mappings, and source/converted data
- Improve error traceability by including field source paths and mapping information
- Standardize logging patterns across all converter classes
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Magento2SalesChannelConverter.php | Adds entity names, field mappings, and source data to sales channel conversion logs |
| Magento2OrderConverter.php | Enhances order conversion logging with detailed field and mapping context |
| Magento2CustomerConverter.php | Improves customer conversion logs with password hash error details |
| LocalMediaProcessor.php | Adds media entity context and source data to media processing logs |
| SeoUrlConverter.php | Enhances SEO URL conversion logs with field mappings and entity context |
| SalesChannelConverter.php | Adds comprehensive logging context for sales channel conversion errors |
| PropertyGroupConverter.php | Improves property group logging with field source paths |
| ProductReviewConverter.php | Enhances product review logs with entity and field mapping details |
| ProductConverter.php | Adds product entity context to tax and price validation logs |
| OrderConverter.php | Comprehensive logging improvements for order conversion with detailed field mappings |
| NewsletterRecipientConverter.php | Updates entity names and adds field context to newsletter recipient logs |
| CustomerConverter.php | Enhances customer conversion logs with detailed field and address mapping context |
| CustomFieldConverter.php | Improves custom field logs with entity names and field source paths |
| CrossSellingConverter.php | Adds product cross-selling entity context to association logs |
| CategoryConverter.php | Enhances category conversion logs with entity names and field source paths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3a2957d to
040f8fc
Compare
040f8fc to
7ba1b01
Compare
a54284c
into
refactor/migration-connection-usage
resolves #12058