Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 18, 2025

1. Why is this change necessary?

There is currently a error on the checkout page if your account is a guest account:

image

2. What does this change do, exactly?

  • Use a empty userIdToken for guest accounts in the SPBCheckoutDataService

3. Describe each step to reproduce the issue or behaviour.

  • Log in as a guest account
  • Continue to the checkout page

4. Please link to the relevant issues (if any).

@ghost
Copy link
Author

ghost commented Mar 18, 2025

@mstegmeyer @FlorianKe @cyl3x Could you take a look at this?

mstegmeyer
mstegmeyer previously approved these changes Mar 18, 2025
cyl3x
cyl3x previously approved these changes Mar 18, 2025
@ghost ghost dismissed stale reviews from cyl3x and mstegmeyer via 6cb3df4 March 18, 2025 10:40
@cyl3x
Copy link
Contributor

cyl3x commented Mar 18, 2025

@akf-bw I'm closing this in favour of #166, #167 and #168. After checking, the system config should also be respected and no token should be fetched. Still, thank you for raising this issue and opening a PR, I appreciate that 💙

@cyl3x cyl3x closed this Mar 18, 2025
cyl3x added a commit that referenced this pull request Mar 18, 2025
cyl3x added a commit that referenced this pull request Mar 18, 2025
cyl3x added a commit that referenced this pull request Mar 18, 2025
Bird87ZA pushed a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants