Skip to content

Conversation

@cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Nov 13, 2025

fixes #463

@cyl3x cyl3x self-assigned this Nov 13, 2025
@cyl3x cyl3x requested a review from mstegmeyer November 13, 2025 10:56
@cyl3x cyl3x marked this pull request as ready for review November 13, 2025 10:56
@mstegmeyer
Copy link
Contributor

I'm not a big fan of the naming of this toggle. Especially if it also toggles Webhooks.

I would name it Block requests from PayPal or Disable external access by PayPal and reverse its functionality. Then you also don't need the update logic.

@mstegmeyer

This comment was marked as resolved.

@cyl3x
Copy link
Contributor Author

cyl3x commented Dec 2, 2025

I'm not a big fan of the naming of this toggle. Especially if it also toggles Webhooks.
I would name it Block requests from PayPal or Disable external access by PayPal ...

@mstegmeyer I know, but this wording leaves room for imagination. It's not like PayPal does arbitrary requests to Shopware, nor is it invasive in any sense. Also, webhooks are callbacks too.

@cyl3x cyl3x requested a review from a team December 3, 2025 14:57
@cyl3x
Copy link
Contributor Author

cyl3x commented Dec 3, 2025

Maybe we can agree on "Is local environment"?

@cyl3x cyl3x changed the title feat: add paypal callback toggle feat: add local environment toggle Dec 9, 2025
@cyl3x cyl3x requested a review from FlorianKe December 9, 2025 10:19
@cyl3x cyl3x requested review from En0Ma1259 and mstegmeyer December 9, 2025 10:39
@cyl3x cyl3x added this pull request to the merge queue Dec 9, 2025
Merged via the queue into trunk with commit 0919181 Dec 9, 2025
26 checks passed
@cyl3x cyl3x deleted the feat/add-paypal-callback-toggle branch December 9, 2025 15:19
cyl3x added a commit that referenced this pull request Dec 10, 2025
cyl3x added a commit that referenced this pull request Dec 10, 2025
cyl3x added a commit that referenced this pull request Dec 10, 2025
cyl3x added a commit that referenced this pull request Dec 10, 2025
cyl3x added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants