-
Notifications
You must be signed in to change notification settings - Fork 2
Improve icon page styling #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
update styling SearchResult restyle icon component hide existing component reference chore: add prism dependancy feat: create codeblock component rename component feat: complete codeblock component remove codeblock index remove import statement rename file style adjustment feat: create background component implement transparency grid implement actionButton feat: re-style search bar feat: apply shopware correct colors feat: remove media queries feat replace prismjs with shiki feat: remove media queries
|
Great idea to include the dynamic viewer component! However, working with the new view made me question whether we should stick with a sidebar. Selecting an icon and then jumping back to the top of the page doesn’t feel right – tags and related icons (based on tags) are also missing. I’d suggest moving everything back to a sticky sidebar that keeps the user in context. Let's connect in Slack :) |
Thanks Dennis, I think you are right the sidebar might be better here. I've returned that, whilst trying to improve the styling a bit and bring it inline with the rest of the documentation. The tags are present but not every icon has tags, so you won't always see them. I've hidden the 'related Icons' because I'm not sure what value they add, given that they are not very specific. Let me know what you think. |
What
Re-style the icon page
Why
To keep this page inline with the rest of shopware.design
How
I've edited the styling across the icon components