fix: correct alignment of buttons in mt-select #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alastair-simon
force-pushed
the
fix/clear-button-alignment-select
branch
from
8595b1a to
56c4cf8
Compare
alastair-simon
force-pushed
the
fix/clear-button-alignment-select
branch
from
83b08fa to
6224305
Compare
Haberkamp
approved these changes
Oct 8, 2025
Contributor
Haberkamp
left a comment
Haberkamp
left a comment
There was a problem hiding this comment.
Ideally, we should do this via CSS, but I get why you chose this solution.
For a ideal solution, we would need to make major adjustments to the component and strip out the base field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #802. This pr fixes the alignment of the clear and drop down button within mt-select
Why?
Currently when a suffix is added to the select, the clear and down button appear on top of the suffix making them difficult to use and a visual error.
How?
I've replaced the absolute positioning with flex, so that the buttons move when suffix is added.