fix: refactor mt-datepicker #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
from
347365d to
c8e07cd
Compare
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
from
c8e07cd to
7335a8e
Compare
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
from
7f6057e to
e7547ce
Compare
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
from
680d704 to
880ab46
Compare
jleifeld
approved these changes
Oct 24, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
from
398abe9 to
b7cf722
Compare
jleifeld
reviewed
Nov 5, 2025
packages/component-library/src/components/form/mt-datepicker/mt-datepicker.vue
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alastair-simon
force-pushed
the
fix/datepicker-timezone-issue
branch
2 times, most recently
from
b7cf722 to
f2ade59
Compare
Haberkamp
approved these changes
Nov 6, 2025
test: add additional tests for timezones fix: timezone issue fix: incorrect timezone value fix: range value fix: range value time fix: time range fix: hide time hint in time mode refactor remove unused timeToIso method fix: time case fix: type error test: add additional test feat: rename methods docs: add dateType select to story fix: improve type guards refactor: allow date objects as props test add default datepicker visual test feat: add hour and minute increment prop to datepicker test: add tests for increment props style: code format update snapshots feat: implement helpText style: code format update snapshots test: simplify timezone fix test add non timezone test style: code format refactor: simplify timezone fix feat: implement text-input test: add test for text input fix: exact match prop naming fix: remove console.log
jleifeld
force-pushed
the
fix/datepicker-timezone-issue
branch
from
f2ade59 to
e82b6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #12926, #938
This pr addresses the following issues with mt-datepicker component:
Why?
This bug and the missing features cause the component to not function as expected
How?
Testing?
I have written a number of additional unit tests to confirm the correct output, I have also create a visual test to ensure the help text is rendered correctly. Additionally I have verified that the changes are backwards compatible in the previous tests.