fix(component-library): fix border-top on card footer #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fabianhueske
reviewed
Dec 1, 2025
packages/component-library/src/components/layout/mt-card/mt-card.vue
Outdated
Show resolved
Hide resolved
fabianhueske
force-pushed
the
add-missing-card-footer-border
branch
from
08521c2 to
e3e8ad0
Compare
fabianhueske
force-pushed
the
add-missing-card-footer-border
branch
from
64733bb to
a29b73b
Compare
fabianhueske
force-pushed
the
add-missing-card-footer-border
branch
from
a29b73b to
fccacca
Compare
fabianhueske
changed the title
fabianhueske
changed the title
fabianhueske
approved these changes
Dec 4, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
sydinh
requested changes
Dec 4, 2025
sydinh
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes border-top from card footer.
Why?
Border currently invisible because of wrong css variable assignment anyway.
How?
Removed border-top.
Testing?
The visual tests should be enough