Skip to content

feat: 3.16.7 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

feat: 3.16.7 #38

wants to merge 12 commits into from

Conversation

felangel
Copy link

Upgrade to 3.16.7

Piinks and others added 12 commits December 7, 2023 21:42
Fixes flutter#139673
Cherry picks flutter#139706 to the stable branch to fix the tree.
…lutter#139782)

As of Xcode 15 on macOS Sonoma, the following message is (repeatedly) output to stderr during builds (repros on non-Flutter apps). It is supppressed in xcode itself, but not when run from the command-line.

```
2023-11-10 10:44:58.031 xcodebuild[61115:1017566] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
Details:  createItemModels creation requirements should not create capability item model for a capability item model that already exists.
Function: createItemModels(for:itemModelSource:)
Thread:   <_NSMainThread: 0x6000027c0280>{number = 1, name = main}
Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
```

This suppresses this message from stderr in our macOS build logs.

Issue: flutter#135277  
Cherry-pick: flutter#139284

https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
…not be run (flutter#139698)

cherry-picks changes from flutter#139614 onto the stable channel
…r#138496) (flutter#139743)

Closes:
- flutter#138434

We will catch any errors while attempting to clear the temp directories that don't exist for the `FontConfigManager` class
…90b2a4691b32d49 fo… (flutter#140424)

�r stable release 3.16.5

roll engine version into framework. (for some reasons conductor didn't auto generate this PR)
…gging from VS Code (flutter#140711)

Update DWDS version on Flutter stable to a hotfix release to resolve dart-lang/webdev#2297

See dart-lang/webdev#2319
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

These tests have been running on master since Nov 28 and the change is already in 3.18 beta. We want to make this change to stable so we can upgrade more bots to macOS 13.

Original PR: flutter#137365

Fixes flutter#140895
Cherry-pick flutter#140823

Issue flutter#140923

This looks like a lot of files, but most of them are updating the version on our integration/examples apps.
…er#141406)

# Flutter stable 3.16.7 Framework

## Scheduled Cherrypicks
@felangel felangel self-assigned this Jan 16, 2024
Copy link

@bryanoltman bryanoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what exactly the issue is, but using cupertino' switch class for comparison (from the cupertino switch issue in shorebirdtech/shorebird#1632), there seems to be a pretty meaningful divergence between what's on this branch and what's on the upstream 3.16.7 (compare https://github.com/flutter/flutter/blob/3.16.7/packages/flutter/lib/src/cupertino/switch.dart and https://github.com/shorebirdtech/flutter/blob/feat/3.16.7/packages/flutter/lib/src/cupertino/switch.dart)

@felangel
Copy link
Author

Not sure what exactly the issue is, but using cupertino' switch class for comparison (from the cupertino switch issue in shorebirdtech/shorebird#1632), there seems to be a pretty meaningful divergence between what's on this branch and what's on the upstream 3.16.7 (compare https://github.com/flutter/flutter/blob/3.16.7/packages/flutter/lib/src/cupertino/switch.dart and https://github.com/shorebirdtech/flutter/blob/feat/3.16.7/packages/flutter/lib/src/cupertino/switch.dart)

Looks like we messed up resolving merge conflicts a while back and the merge strategy won't catch those. I'm going to close this and open a new PR where I rebase so that we can get back on track.

@felangel felangel closed this Jan 16, 2024
@felangel felangel deleted the feat/3.16.7 branch February 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.