for #25762: Add platform and python version info to user-agent #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonvfx
added a commit
that referenced
this pull request
Jul 1, 2014
…r_agent for #25762: Add platform and python version info to user-agent
|
Looks good, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the platform that the script is running on, and python version in order to be a little more consistent with the user-agent that any typical browser would send.
There's also server-side code that attempts to assign the platform for the current user. Since the API doesn't send any information that helps the server determine what platform it's running from, the server sets it to blank. This could possibly cause issues when doing things like matching against LocalStorage paths, etc. which require platform information.
Old default user agent string:
shotgun-json (3.0.17)New default user agent string:
shotgun-json (3.0.17); Python 2.6 (Mac)