Adds per-project visibility querying on schema methods #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisjacques
force-pushed
the
27860_project_customization
branch
from
de68ec2 to
901478f
Compare
| @@ -945,23 +945,39 @@ def followers(self, entity): | |||
|
|
|||
| return self._call_rpc('followers', params) | |||
|
|
|||
| def schema_entity_read(self): | |||
| def schema_entity_read(self, project_entity=None): | |||
There was a problem hiding this comment.
Hey there! It would be great if we could have a `:param: style docstring for this new parameter - just for consistency with other methods! Thanks!
There was a problem hiding this comment.
ya, agree, will do
|
Thanks for the fixes! Looks sweet! 🍰 |
- updated schema_.*read methods for project argument
- add new unit tests to validate querying per project
- updated README
- updated date in changelog
francoisjacques
force-pushed
the
27860_project_customization
branch
from
166b3b8 to
3a06ab7
Compare
francoisjacques
added a commit
that referenced
this pull request
Mar 13, 2015
Adds per-project visibility querying on schema methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.