-
Notifications
You must be signed in to change notification settings - Fork 73
Feature/actix web example #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/actix web example #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me. I'm just wondering if the example can be simplified?
actix-web/hello-world/src/lib.rs
Outdated
#[shuttle_service::main] | ||
async fn actix_web( | ||
) -> ShuttleActixWeb<impl FnOnce(&mut ServiceConfig) + Sync + Send + Copy + Clone + 'static> { | ||
let h = hello_world; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be needed for all routes? Ie assigning the pointer to a variable first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not required. Actually it was part of my experiments with closures. Fix pushed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, just one small suggestion. Thanks!
Co-authored-by: Oddbjørn Grødem <[email protected]>
This is good to go @biryukovmaxim, we're just gonna wait with merging it until we're ready to release, so nobody gets confused about if they can use actix yet 😄 We're working on a few other features as well, but it shouldn't be too long. |
No description provided.