Skip to content

Feature/actix web example #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2022

Conversation

biryukovmaxim
Copy link
Contributor

No description provided.

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. I'm just wondering if the example can be simplified?

#[shuttle_service::main]
async fn actix_web(
) -> ShuttleActixWeb<impl FnOnce(&mut ServiceConfig) + Sync + Send + Copy + Clone + 'static> {
let h = hello_world;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be needed for all routes? Ie assigning the pointer to a variable first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not required. Actually it was part of my experiments with closures. Fix pushed

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, just one small suggestion. Thanks!

@biryukovmaxim biryukovmaxim requested review from oddgrd and removed request for chesedo November 29, 2022 13:41
@oddgrd
Copy link
Contributor

oddgrd commented Nov 29, 2022

This is good to go @biryukovmaxim, we're just gonna wait with merging it until we're ready to release, so nobody gets confused about if they can use actix yet 😄

We're working on a few other features as well, but it shouldn't be too long.

@oddgrd oddgrd merged commit 02b4208 into shuttle-hq:main Dec 9, 2022
shiraazAh added a commit to shiraazAh/shuttle-examples-t that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants