Feature/actix web example #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
approved these changes
Nov 29, 2022
Contributor
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
This seems good to me. I'm just wondering if the example can be simplified?
actix-web/hello-world/src/lib.rs
Outdated
| #[shuttle_service::main] | ||
| async fn actix_web( | ||
| ) -> ShuttleActixWeb<impl FnOnce(&mut ServiceConfig) + Sync + Send + Copy + Clone + 'static> { | ||
| let h = hello_world; |
Contributor
There was a problem hiding this comment.
Will this be needed for all routes? Ie assigning the pointer to a variable first?
Contributor
Author
There was a problem hiding this comment.
No, it's not required. Actually it was part of my experiments with closures. Fix pushed
oddgrd
approved these changes
Nov 29, 2022
Collaborator
oddgrd
left a comment
oddgrd
left a comment
There was a problem hiding this comment.
LGTM too, just one small suggestion. Thanks!
Co-authored-by: Oddbjørn Grødem <[email protected]>
Collaborator
|
This is good to go @biryukovmaxim, we're just gonna wait with merging it until we're ready to release, so nobody gets confused about if they can use actix yet 😄 We're working on a few other features as well, but it shouldn't be too long. |
shiraazAh
added a commit
to shiraazAh/shuttle-examples-t
that referenced
this pull request
Sep 10, 2024
AdepojuJeremy
pushed a commit
to AdepojuJeremy/shuttle-examples
that referenced
this pull request
Sep 19, 2025
…example Feature/actix web example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.