Repository navigation
Floor refusal tests: 15 of 24 untested refusals pinned (finding 110) - #118
Merged
Merged
Conversation
shuv-amp
force-pushed
the
auto/A/fuzz-record
branch
from
October 17, 2026 22:54
9d7cf88 to
067ea3c
Compare
shuv-amp
force-pushed
the
auto/A/floor-error-tests-r6
branch
from
October 17, 2026 22:54
5466cca to
66d1afd
Compare
shuv-amp
force-pushed
the
auto/A/fuzz-record
branch
from
October 18, 2026 20:04
067ea3c to
e57e5fb
Compare
shuv-amp
force-pushed
the
auto/A/floor-error-tests-r6
branch
from
October 18, 2026 20:04
66d1afd to
ada0239
Compare
shuv-amp
force-pushed
the
auto/A/fuzz-record
branch
from
October 19, 2026 16:59
e57e5fb to
7eef1dc
Compare
…owns
Three checks survived deletion with every program test green
(tasks/error-codes-floor/mutants.log, base 43bfa31, full program
suite): lib.rs:179, load_config's "Floor owns the config";
state.rs:132, Config::load's length and discriminator; and
loader.rs:14, check_frozen_buffer's "the loader owns the buffer". No
test sent Floor a copy of its own account under another owner, or an
account Floor owns but never wrote, and the substitution sweep only
swaps in real accounts.
What each guards, seen with the check deleted (STATE=c1, and r5c1 on
the final test):
F01 lib.rs:179: a copy of a program's config under another owner,
naming a thief as the owner and no abort buffer staged, is read
as the config. close_buffer never writes the config, so the loader
closes the REAL staged abort buffer (frozen to the real Floor
authority) and pays its rent to the thief ("Closed Buffer ..." in
test-c1-F01.log). The real config still names the closed buffer,
so every stop fails until a live quorum stages another.
F02 state.rs:132: anyone can create an account Floor owns (a system
CreateAccount assigns it, without Floor). A zero-filled one of a
config's length, created by the thief, is read as a config, and a
heartbeat naming it is refused only later, as 7014 NotLiveGuardian.
F13 loader.rs:14: a byte-identical copy of the pinned snapshot under
its writer is pinned, a buffer the loader could never install.
New test floor_reads_only_a_config_it_wrote_and_a_buffer_the_loader_
owns: the forged config's close -> NOT_A_FLOOR_CONFIG; the heartbeat
on the thief's zero-filled Floor account -> NOT_A_FLOOR_CONFIG;
pinning the copied snapshot -> NOT_LOADER_V3. Helper copy_under copies
an account to a fresh address under another owner.
Evidence (tasks/error-codes-floor/mutants.log, STATE=c1 and r5c1, full
program suite): F01, F02 and F13 KILLED by the new test; all three
SURVIVED at base. Floor hash 8ca8a608 unchanged (tests only). The
run's base, 43bfa31, is a commit of the earlier vault-error-tests-r3
branch, not of this history; its programs and core equal this
commit's (git diff --stat 43bfa31 HEAD -- programs/floor/src
programs/vault/src programs/harbor/src crates/: empty).
Counts: Floor 50 -> 51, programs 165 -> 166 (claims.py OK).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three registration checks survived deletion with every program test
green (tasks/error-codes-floor/mutants.log, base 43bfa31): register.rs:63,
"the program names this programdata", register.rs:58, "the loader
owns the program and the programdata", and register.rs:69, "the
programdata has a header". Registration takes the upgrade authority
from that programdata, so these are what make the signer the
program's own authority.
Seen with each check deleted (STATE=r2c2), or for :69, whose code is a
value, changed to another code:
F07 register.rs:63: a thief registers another team's program with the
thief's own programdata, of which the thief holds the key. It
SUCCEEDS: the loader moves the thief's programdata to Floor, and
the config at the team's program address is the thief's. The team
could never register.
F06 register.rs:58 (and F06a, the program clause of :57 alone): a
copy of the team's program account under another owner, naming
the thief's real programdata, is registered. It SUCCEEDS: a config
for an address the loader never deployed, holding the thief's
programdata.
F08 register.rs:69: the program's upgrade authority closes the
programdata with the loader and registers, in one transaction. A
closed programdata stays loader-owned until the transaction ends,
and the program still names it, so :57 and :63 pass and :69 is
the check that refuses (found by B's review of r5, probe
tasks/review-floor-error-tests-r5/zz_probe_b.rs). With :69 mapped
to InvalidInstruction (F08) or Overflow (F08o), the registration
fails with that code instead of PROGRAM_MISMATCH. Across two
transactions the programdata is gone and :57 refuses first
(NOT_LOADER_V3), so only the same-transaction case reaches :69.
F06b, the programdata clause of :57 alone, SURVIVES, and the test's
comment says so: a program the loader owns names its own
programdata, which the loader owns too, so :63 refuses any other.
Covered only jointly.
New test registration_reads_only_the_programs_own_programdata: the
thief's programdata -> PROGRAM_MISMATCH; the copied program ->
NOT_LOADER_V3; the team's Close then register in one transaction, for
both forms of the close (SIMD-0432 tombstone false and true) ->
PROGRAM_MISMATCH at instruction 1; then the team registers, and Floor
holds its key (the failed transactions undid the closes). copy_under
now clears `executable`: LiteSVM refuses an executable account no
loader owns, and a copied program needs it off.
Evidence (tasks/error-codes-floor/mutants.log, STATE=r2c2, full program
suite): F06, F06a, F07 KILLED by the new test; F06 and F07 SURVIVED at
base; F06b SURVIVED (joint, above). F08 and F08o
(tasks/floor-error-tests-r6/mutants.log, full program suite): KILLED
by the new test alone at STATE=r6wip (Floor 56 passed / 1 failed,
Vault 115 passed; "left: InstructionError(1, Custom(7034)) right:
InstructionError(1, Custom(7006))" for F08o), and both SURVIVED with
the test file as it was before this case (STATE=r6parent). Floor hash
8ca8a608 unchanged.
Counts: Floor 51 -> 52, programs 166 -> 167 (claims.py OK).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two registration refusals had no test that saw their code
(tasks/error-codes-floor/mutants.log, base 43bfa31):
F05 register.rs:53, the system program account: with the check
deleted the registration still fails, at the CPI ("Unknown
program 1111...", MissingAccount, no custom code; STATE=c3).
F34 guardians.rs:49, a heartbeat interval outside 1 to 30 days maps
to InvalidInterval. No case sent one, so mapping it to
InvalidGuardians left every test green.
registration_rejects_weak_settings gains intervals 1 day - 1 s and
30 days + 1 s, each just past its bound (INVALID_INTERVAL), and
registers two more programs at exactly 1 day and exactly 30 days,
which are accepted. New test registration_names_the_system_program:
slot 6 replaced -> WRONG_PROGRAM, then the same registration with the
real system program succeeds.
Not tested: register.rs:88 (AlreadyRegistered). Once registered, Floor's
PDA holds the upgrade key, so a second registration is refused at
:70 (NOT_CURRENT_AUTHORITY, seen while writing this test), and a release
closes the config in the transaction that hands the key back.
Evidence (STATE=c3, full program suite): F05 KILLED by
registration_names_the_system_program, F34 KILLED by
registration_rejects_weak_settings (7008 where 7010 is expected); both
SURVIVED at base. F35, the core range made exclusive at the top
(governance.rs:216, ..= to ..), is KILLED by the 30-day registration
(STATE=r3c3: 7010 for an interval the spec allows). Floor hash
8ca8a608 unchanged.
Counts: Floor 52 -> 53, programs 167 -> 168 (claims.py OK).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven checks survived deletion (tasks/error-codes-floor/mutants.log,
base 43bfa31) because something later still refused the case: the
loader, or another Floor check with its own code. Each now has a test
that sees Floor's own code, and each was seen to fail with the check
deleted (STATE=c4, full program suite):
F15 loader.rs:141, a stop naming another program's programdata, or
its program, each on its own -> PROGRAM_MISMATCH. Gone: the loader
refuses (IncorrectAuthority, no custom code). Each clause of :140
dropped alone (F15a, F15b) is also killed.
F12 lib.rs:200, a stop naming another program's Floor authority ->
WRONG_AUTHORITY_ADDRESS. Gone: PrivilegeEscalation.
F14 loader.rs:72, a stop with the clock in the rent slot, or the rent
in the clock slot -> WRONG_SYSVAR. Gone: InvalidArgument from the
loader. Each clause of :71 dropped alone (F14a, F14b) is killed.
F21 stop.rs:205, a quorum restore while live -> NOT_ABORTED. Gone:
7024 NoValidSnapshot (snapshot_valid is 1 only between a stop and
the next return to live).
F20 stop.rs:122, a stop after a restore, with no abort buffer staged,
naming the all-zero address or the used-up buffer ->
NO_ABORT_BUFFER. Gone: the all-zero address equals the empty slot,
so the stop reaches the loader (PrivilegeEscalation); the used-up
buffer gets 7021 WrongBuffer.
F25 proposals.rs:104, a proposal of unknown kind 99 ->
WRONG_PROPOSAL_KIND, and the slot stays empty. Gone: the proposal
SUCCEEDS; from the code it then holds the slot until cancelled,
and execute refuses it (:245).
F31 proposals.rs:337, a release naming another program's programdata
-> PROGRAM_MISMATCH, and that programdata keeps its Floor
authority. Gone: IncorrectAuthority from the loader.
New tests: a_stop_names_its_own_program_sysvars_and_authority (then the
real stop succeeds, and the other program still runs),
a_restore_needs_a_stop_and_a_stop_needs_an_abort_buffer,
a_proposal_has_a_known_kind_and_a_release_its_own_programdata (then the
real release hands the key over).
Evidence: all seven, and F14a F14b F15a F15b, KILLED by the tests
named above (STATE=r2c4); all seven SURVIVED at base. Floor hash
8ca8a608 unchanged (tests only).
Counts: Floor 53 -> 56, programs 168 -> 171 (claims.py OK).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ten of the 34 places the deletion run covers (tasks/error-codes-floor/
mutants.log, base 43bfa31) were killed at base, but only by tests that
check that something fails, not with which code: the substitution
sweep (every_floor_account_substitution_is_refused) or the random
differential (floor_matches_the_core_model_on_random_sequences). So
the code each returns was asserted nowhere: 7002 and 7016 not at all,
and 7006, 7003, 7017, 7027 not at these sites.
New test each_instruction_names_its_own_accounts_and_state. Each case
names what the check would otherwise let through, and with the check
deleted, the five marked * SUCCEED (STATE=r4c5, "got success"):
F09 register.rs:82 config not at Floor's PDA -> WRONG_CONFIG_ADDRESS
F10 register.rs:85 authority not at Floor's PDA
-> WRONG_AUTHORITY_ADDRESS
F16*stop.rs:35 a replacement abort buffer, checked against
another program's programdata
-> PROGRAM_MISMATCH
F18*stop.rs:68 a pin of the other program's code, naming its
programdata -> PROGRAM_MISMATCH
F22*stop.rs:296 a close of a copy of the live code (which a stop
may name, finding 85), naming another programdata
-> PROGRAM_MISMATCH, and the copy keeps its rent
F24 proposals.rs:73 a restore proposal while live -> NOT_ABORTED
F27 proposals.rs:181 an approval of a pending upgrade, by its own id
-> WRONG_PROPOSAL_KIND; no approval is recorded
F23 proposals.rs:68 an upgrade proposal while stopped -> NOT_LIVE
F17*stop.rs:65 a pin while stopped of a copy of what now runs
(the abort binary) -> NOT_LIVE
F19*stop.rs:117 a second stop, naming the pin, through an abort
buffer anyone may stage while stopped -> NOT_LIVE;
aborted_at, the pin and its validity are unchanged
Found by code review of this branch: pass 1 (NOT_LIVE never asserted
by value), passes 2 and 3 (approve a pending UPGRADE, not nothing; each
case must reach the path its check guards, not a later refusal).
Evidence (tasks/error-codes-floor/mutants.log, STATE=r4c5, full program
suite): all ten KILLED by the new test (each also by the sweep or the
differential, as at base), and F27b (approve's kind check narrowed to
"nothing pending") KILLED: that approval then succeeds. Floor hash
8ca8a608 unchanged.
Counts: Floor 56 -> 57, programs 171 -> 172 (claims.py OK).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/09 §3 gains a row beside the Vault one, for the Floor deletion run
this branch answers (tasks/error-codes-floor/mutants.log): every place
that returns one of the 14 Floor codes no test asserted by value
(7001-7006, 7010, 7016, 7017, 7019, 7027, 7032-7034), 34 in all, each
removed on its own with the whole program suite run against it, on the
AUD-2 build: a `return Err` dropped, a checked value's `?` replaced by a
default (proposals.rs:120, :443), a match arm's error made a success
(:245). register.rs:69 and the interval mapping guardians.rs:49 return
a value that cannot be dropped, so they were changed to another code.
At base: 10 KILLED, all by the sweep or the differential, which do not
check the code ("Assert the Floor codes only the sweep and the
differential saw" asserts each), and 24 SURVIVED. (The first run
reported F30 KILLED with no test named: that run died partway. Run
alone, F30 survives with every suite green; the runner now reports
such a run as ABORTED.) The first four Floor commits on this branch
kill 15 of the 24 (F01 F02 F13, F06 F07 F08, F05 F34, F12 F14 F15 F20
F21 F25 F31). The row says how register.rs:69 is reached (one
transaction: the loader's Close of the programdata, then the
registration; found by B's review of r5, which called it unreachable).
It names the 9 that still survive and why no transaction is known to
reach them:
- state.rs:174 (stored bounds), :181 (length at store): Floor creates an account only in register
(register.rs:105-145), at the config's length, and stores only
checked values (payload proposals.rs:62, guardian sets parsed).
- register.rs:88: :70 refuses a second registration first
(NOT_CURRENT_AUTHORITY, seen while writing the system-program test).
B's review tried a same-transaction release then register: the
release closes the config, and with Floor holding the key nobody
can sign as the current authority.
- proposals.rs:120, :443: u64 proposal id; lamport sum.
- proposals.rs:245, :496: propose refuses an unknown kind (:104).
- proposals.rs:273, :278: an UPGRADE is proposed only while live (:68),
a RESTORE only while stopped (:73); a stop and each return to live
clear the owner's proposal (stop.rs:176, :252, proposals.rs:317); the
recovery key proposes only SET_OWNER or SET_RECOVERY (:28).
Re-run on 17 Oct at this branch's tip, all 43 mutants of
tasks/error-codes-floor/mutants.txt plus F08o (:69 mapped to Overflow,
B's form of F08), with the whole program suite
(tasks/floor-error-tests-r6/mutants.log, STATE=r6tip): 34 KILLED, 10
SURVIVED (the 9 above and F06b), each the same as in the 16 Oct tip
run (tasks/error-codes-floor/run-tip.out) except F02 and F08, now
KILLED. The programs did not change: git diff --stat 43bfa31
HEAD -- programs/floor programs/vault/src crates/bulkhead-core/src is
empty, and the Floor hash is 8ca8a608 before and after.
The row also says that the programdata clause of register.rs:57 is
covered only jointly with :63 (F06b survives alone).
It ends with the two codes still asserted by no test, AlreadyRegistered
(register.rs:88) and Overflow (proposals.rs:120, :443), each returned
only by one of the 9. And it says what was not deleted: the calls of
the shared checks check_program_accounts and check_authority, only
their returns (loader.rs:141, lib.rs:200). With each of the eight
calls replaced by `let _ = ...` (tasks/floor-check-calls/mutants.log,
17 Oct), the two in a stop are KILLED, and the six in restore_snapshot,
close_buffer, execute_code and execute_release SURVIVE with every test
green, the sweep included: the loader still refuses, with no Floor
code. Those are a follow-up of their own.
Docs only: no count change (claims.py OK: Floor 57, programs 172).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Floor deletion run of 16 Oct (09 §3, "Floor refusals deleted one at a time", recorded in the previous commit) is finding 108's sibling: every place that returns one of the 14 Floor codes no program test asserted by value, deleted on its own with the whole program suite run against it. 24 of 34 survived; the other 10 failed only the sweep or the random differential. That is finding 106's class, enforced but untested rules, so it is a finding of its own (reserved 17 Oct 08:08Z, FINDINGS-RESERVED). The row restates the §3 row and adds nothing to it: what survived (the config copy that lets a stranger close the real abort buffer, an account Floor owns but never wrote, a pin of a buffer the loader does not own, another team's program registered with the registrant's programdata), the 15 now pinned plus the 10 the sweep and differential saw, and the 9 left (no transaction known to reach them) with register.rs:57's joint clause. The two test names cited each exist once in programs/tests/tests/floor.rs (git grep -c). The programs did not change on this branch (see the previous commit). README:194 and docs/12:22 count 110 findings, 96-110 recorded 13-17 Oct. tools/claims.py: claims OK (26 files), findings 110. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuv-amp
force-pushed
the
auto/A/floor-error-tests-r6
branch
from
October 19, 2026 17:02
ada0239 to
c90d85a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Program tests (programs/tests/tests/floor.rs) and docs (docs/09, README, docs/12). No program change: Floor stays 8ca8a608, and
git diffof programs/*/src and crates/bulkhead-core/src against the base is empty. Seven commits.The Floor deletion run, the sibling of the Vault run in #100, removed every place that returns one of the 14 Floor error codes no test asserted by value, 34 in all, each on its own with the whole program suite run against it. 10 failed only the account sweep or the random differential, which check that a step fails but not its code. 24 survived with every test green. Among them:
a copy of a config under another owner could make Floor close the real abort buffer and pay its rent to a stranger (lib.rs:179);
an account Floor owns but never wrote was read as a config (state.rs:132);
another team's program could be registered with the registrant's own programdata (register.rs:63).
e68f303, d4d128a, 683c080, 82ecd78: tests that see Floor's own code for 15 of the 24: config ownership and shape, the loader owning a frozen buffer, registration reading only the program's own programdata and loader accounts, the system-program and heartbeat-interval refusals, and seven refusals another layer backstops.
d1273fc: asserts the code of the 10 the sweep and differential saw only as "it failed" (five of them succeed with their check deleted).
29e6d87: docs/09 §3's row for the run.
ada0239: records finding 110.
Proof
Custom(PROGRAM_MISMATCH). With :69 changed to Overflow or InvalidInstruction, only that assertion fails (Floor 56/1, Vault 115/115). Both mutants pass r5's tests. The counts are now 15 pinned / 9 unreachable.scripts/check.shALL CHECKS PASSED (findings 110, Floor 57, programs 172).Limits
Hashes after the sync onto main (17 Oct)
sync-main-97 replayed the stack onto main d7b9bdb (#97), after the owner's README redesign (#115). Each commit's own diff is unchanged, except README hunks ported to the new README. Outside README, every old/new pair differs only by main's own changes (autopilot tasks/sync-main-115/per-commit-tree.log treebad=0, tasks/sync-main-97/pairs.log bad=0). The ids under What changed are the new ones; the runs and reviews quoted elsewhere were done at the old ones. Old = new: d9420a3 = 1b22697, 8044746 = a402edb, 1c8b44d = 0d3fafb, 684f0f7 = d74c2fd, e97ad77 = 1d648fe, 8d2fd11 = 0c6e3ab, 5466cca = 66d1afd. On the synced chain:
bin/check-each-commit.sh60/60 green, andscripts/check.shALL CHECKS PASSED at its tip 2fa7a7f (tasks/sync-main-97/each-commit.log, check-tip.log). Agent B reviewed the sync: REVIEWS/auto-A-sync-main-97.md (APPROVE).Hashes after the sync onto main (19 Oct)
The sync replayed the stack onto main bb55c15 (#114), whose tree is auto/B/failover-snapshot-r2's (8506759); #113's is auto/B/floor-follow-each's (51d20d3), both built on the main they merged into. The owner's #107 edited one sentence in README.md, docs/08 and docs/09 (the devnet job, and with it
ci, fails for Floor and Vault until finding 107 is deployed); and #99's merge changed README's devnet line and the guardians figure (3-8 -> 4-8 keys). Each commit's own message is unchanged. Every old/new pair's trees differ by exactly that: README.md, docs/08, docs/09, docs/assets/src/figures.py and the two PNGs, the same +/- lines for all 38 synced commits (autopilot tasks/sync-main-114/per-commit-tree.log and map.txt). The ids under What changed are the new ones; the runs and reviews quoted elsewhere were done at the old ones. Old = new: 1b22697 = e68f303, a402edb = d4d128a, 0d3fafb = 683c080, d74c2fd = 82ecd78, 1d648fe = d1273fc, 0c6e3ab = 29e6d87, 66d1afd = ada0239. On the synced chain:bin/check-each-commit.sh bb55c1541/41 green (the 38 synced commits, then the murmur3 exclusion fix, finding 106's citation and the full-ledger fuzz target), andscripts/check.shALL CHECKS PASSED at their tip (tasks/sync-main-114/each-commit.log, check-tip.log). Agent B reviewed the sync: REVIEWS/auto-A-sync-main-114.md.🤖 Generated with Claude Code