Repository navigation
External review: findings 132–141 fixed - #151
Merged
Merged
Conversation
…ication, build) Vault: a deposit into a full ledger is refused (NoSlot) instead of accepted with no backing (132); execute_change takes a recovery-key proposer only for SetAdmin and SetRecovery (133); a lifeboat exit does not execute while the protocol or the vault is frozen (134). One LiteSVM test per fix, each failing on the previous build. Cloud guardian: replayed releases with no block time are dated by slot or left out of the rolling windows (135); a mint with no attest is recorded and judged once attest succeeds, not frozen on a worst case of 0 (136); the protocol read slot is kept in the state file and used on the first read after a restart (137); the freshness cross-check compares monotone on-chain counters across admitted endpoints (138); bounded cancel sweep, non-throwing decoders and balance parser, an instance lock, no hold renewal once covered, config permission warning, strict 32-byte keys (139). Seven tests in cloud/test/review.test.mjs. Verification: the Python reference's set_windows early exit removed; two exhaustive ledger tests against an independent oracle; a full-width Kani harness for the low-water balance; counts corrected and checked by tools/claims.py (140). Build: cargo-build-sbf version asserted and platform-tools installed explicitly with a loud failure; --locked on the check and release paths; deploy gate over every tracked file; floor-devnet.sh no longer deploys on an RPC error; COMPETITIVE_*.md ignored (141). Docs: 03, 05, 07, 09 §2/§4/§5, 12, 14, FAQ updated; the review report is docs/17. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
shuv-amp
force-pushed
the
review/findings-105-114
branch
from
October 22, 2026 12:42
01ef095 to
0d5ceb1
Compare
shuv-amp
enabled auto-merge (squash)
October 22, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the 22 Oct external review, rebased onto
mainat #148. Each finding is logged indocs/09-VERIFICATION.md§4 as 132–141 (105–131 landed onmainmeanwhile); the report isdocs/17-EXTERNAL-REVIEW.md.Vault (one LiteSVM test per fix, each fails on the previous build)
NoSlotinstead of accepted with no backing.execute_changeaccepts a recovery-key proposer only forSetAdminandSetRecovery.execute_lifeboat_exitis refused withFrozenwhile the protocol or the vault is frozen.Cloud guardian (7 tests in
cloud/test/review.test.mjs)getBlockTime, or kept out of the rolling windows with an error log, instead of stamped with the wall clock.attestis recorded and judged once the figure arrives, instead of frozen against a worst case of 0.minContextSloton the first read after a restart; the startup sync retries instead of exiting.<stateFile>.lock); no hold renewal once the chain covers the hold's end; config file permissions are reported;key()requires exactly 32 bytes.Verification (140)
reference/bulkhead_ref.py:set_windowsno longer returns early on an unchanged window, matching the Rust.backed_amountagainst an independent oracle: the u128-overflow region (every ledger up to 48 units) and maximality at full width.low_water_never_counts_fresh_capital(full width); all 20 harnesses verified.tools/claims.pypasses.Build and scripts (141)
build-programs.shassertscargo-build-sbf 4.3.0, installs platform-tools v1.57 explicitly and fails if it cannot;--lockedon every cargo call incheck.sh,check-programs.sh,build-programs.sh,build-harbor.shand CI.deploy.shrefuses any uncommitted tracked file and logs the commit;floor-devnet.shtreats an RPC error as unknown, not as "not deployed"..gitignore:COMPETITIVE_*.md.Not run here: the programs rebuilt for sBPF v3 and the 182 LiteSVM tests against them (the review machine could not fetch platform-tools). Against the 14 Oct binaries, 174 of 182 pass; the 8 failures are the tests of on-chain rules that build lacks (this PR's three, and
main's five for findings 107, 115 and 116).scripts/check.shandscripts/prove.shpass on this tree.🤖 Generated with Claude Code