Skip to content

ci: report coverage data to Codecov #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Mar 12, 2024

There are some different behaviors as mentioned by @sidorares in #2472 (comment):

  • New and old MySQL Server versions
  • SSL as 0 and 1
  • Compression as 0 and 1

As the tests now run equally for all versions of Node.js and both platforms (OS), there's no need to send a report for each version of them.

That's why I opted to create an individual CI for the coverage report.

Naturally, to compare the coverages with the master branch, CI - Coverage will now be run for each push on the master too.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@wellwelwel wellwelwel marked this pull request as ready for review March 12, 2024 04:51
@wellwelwel
Copy link
Collaborator Author

Screen Recording 2024-03-12 at 01 49 19

@wellwelwel wellwelwel merged commit f5f5b1b into sidorares:master Mar 12, 2024
@wellwelwel wellwelwel deleted the coverage branch April 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants