Feature/attendance viewer#319
Conversation
cjwagn1
left a comment
cjwagn1
left a comment
There was a problem hiding this comment.
- "Radio interested: Attended" doesn't make too much sense
- Should not be a null%
Make it mobile-friendly
Other:
- Change URL to "/events/data/:id" instead of the current "/data/:id". Perhaps just "events/:id" and remove the data part entirely?
- Notify the user if it failed to fetch and when you reconnect with a little popup
Warnings:
Limit the number of warnings as best you can
- admin-web:
- profile-web:
Profile-web things:
What if recordInterest fails?
ClayMav
left a comment
ClayMav
left a comment
There was a problem hiding this comment.
with 2 events without interest/attendance (old ones) after adding 1 attendance to the only event with an attendance code, it moved from 3rd rank to 2nd - intended behavior should be ? to 1st
if you go to a url for a nonexistent key it just kinda works like an event with no data which seems broke
Comments on carters:
I dont mind the ratio title.
null% is definitely a little strange.
Mobile friendly probably doesn't make sense here since we again use the tables from antd - like membership and mobile is not very nice for those. In the future this will need to be addressed.
events/:id definitely ideal.
failing to fetch needs to be considered.
It is a startling amount of warnings, definitely more than I am comfortable with.
I love this feature, definitely excited to see how we incorporate it into the events page and I think this will be a really killer feature for the executives. Thanks for the amazing work Andrew!
| if(eventUrlKey == null) { | ||
| return ( | ||
| <Modal | ||
| title={"Registration Link Error"} | ||
| visible={visible} | ||
| footer={null} | ||
| onCancel={handleCancel} | ||
| > | ||
| <h2>This event does not have a registration URL key.</h2> | ||
| </Modal> | ||
| ); | ||
| } |
There was a problem hiding this comment.
probably should generate one
There was a problem hiding this comment.
This will never apply to newly-created events. Only past events (before ~October or something) won't have a key.
KerimD
force-pushed
the
feature/attendance-viewer
branch
from
aee58d7 to
f59c512
Compare
4 participants
Pull Request Description
Checklist:
Added the event data page for tracking attendance/interest for each event. The page can be found at admin.mstacm.org/data/{urlKey}. QR/links for tracking interest/attendance have also been moved here.
NOTE: Eventually, this should be linked to from the events tool. Given the admin-web redesign, I haven't done anything with that yet, but it will at some point become necessary, as the urlKey will not be accessible from the events page once the events page is updated and the link is moved to the data page.