Skip to content

Make mstacm api production ready #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 1, 2019
Merged

Make mstacm api production ready #65

merged 7 commits into from
Sep 1, 2019

Conversation

kevinschoonover
Copy link
Contributor

@kevinschoonover kevinschoonover commented Aug 29, 2019 •
edited
Loading

Pull Request Description

Add changes to the api to allow create of migrations properly for production systems.

TODO

  • Add the correct sub for [email protected]
  • Add ci/cd through circleci
  • Add deployment documentation
  • fix yarn start:prod on dockerfile

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ClayMav
ClayMav reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have good enough understanding of CircleCI, so need that all explained to me.

@kevinschoonover
Copy link
Contributor Author

This PR is ready to be fully reviewed @ClayMav @dmgardiner25

ClayMav
ClayMav approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thoroughly satisfied with this.

@kevinschoonover kevinschoonover merged commit 7450258 into develop Sep 1, 2019
@kevinschoonover kevinschoonover deleted the feature/production branch September 1, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayMav ClayMav ClayMav approved these changes

@dmgardiner25 dmgardiner25 Awaiting requested review from dmgardiner25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinschoonover @ClayMav