Add unit tests for FindByViewModel. #14145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sagar0-0
force-pushed
the
sagar/test-findbyvm
branch
from
d9f4821 to
ba29fe1
Compare
cody-signal
reviewed
May 19, 2025
| @@ -195,7 +193,7 @@ class FindByActivity : PassphraseRequiredActivity() { | |||
| val cleansed = state.userEntry.removePrefix(state.selectedCountry.countryCode.toString()) | |||
| E164Util.formatAsE164WithCountryCodeForDisplay(state.selectedCountry.countryCode.toString(), cleansed) | |||
| } | |||
| stringResource(id = R.string.FindByActivity__s_is_not_a_valid_phone_number, state.userEntry) | |||
There was a problem hiding this comment.
I think we want to keep this as the user provided input instead of the formatted input so things match what the user sees/entered.
There was a problem hiding this comment.
So we can also remove the formattedNumber.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been closed due to inactivity. |
|
Should this be reopened? |
cody-signal
pushed a commit
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 100% test coverage with some refactoring.