Skip to content

Bump electron-builder to version 19.47.0 #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump electron-builder to version 19.47.0 #1835

wants to merge 2 commits into from

Conversation

veggiedefender
Copy link
Contributor

@veggiedefender veggiedefender commented Nov 29, 2017

fixes #1829

First time contributor checklist

Contributor checklist

  • My contribution is fully baked and ready to be merged as is
  • [X?] My changes are rebased on the latest master branch
  • My commits are in nice logical chunks
  • I have followed the best practices in my commit messages
  • I have tested my contribution on these platforms:
  • Arch 4.13.12-1-ARCH
  • My changes pass all the local tests 100%
  • I have considered whether my changes need additional tests, and in the case they do, I have written them

Description

This pull request upgrades electron-builder to a version that allows installing dependencies on Linux systems that do not support the C.UTF-8 locale:

electron-userland/electron-builder@41920bf

@scottnonnenberg
Copy link
Contributor

I've discovered, when doing previous updates, that there are two other dependencies that should probably be updated at the same time: electron-updater and electron-publisher-s3. Can you figure out which versions of these dependencies go along with 19.47.0?

Also, to verify that everything is working, please try these commands:

yarn generate
yarn build-release
grunt test-release:osx --dir=release

You can replace osx with lin or win as appropriate.

Upgrading electron-builder without upgrading these two packages results in a failed build
@veggiedefender
Copy link
Contributor Author

the commit I just pushed fixes builds I think. I only have a linux machine to test on but both grunt unit-tests and grunt test-release:linux --dir=release passed.

also, would it be a good idea to add those commands to the tests section of CONTRIBUTING.md?

@scottnonnenberg
Copy link
Contributor

Might add that to CONTRIBUTING.md but not many people are messing with our build/publish dependencies! :0)

@scottnonnenberg
Copy link
Contributor

This is on hold until I've reviewed the electron-builder release notes - I seem to recall that there was a pretty big breaking change, and we needed to introduce some sort of compatibility option.

@scottnonnenberg
Copy link
Contributor

Superceded by #1920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing dependencies breaks on Arch (possibly all non-debian based distros)
2 participants