Skip to content

#5953 Fix for conversation animation when keyboard is shown #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

armartinez
Copy link

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16 Pro, iOS 18.3.2

Description

This fixes issue #5953 when opening the keyboard on a conversation. What is happening is that items that will be pushed out of the frame are removed before the system animation begins so when it starts they are faded out as removed items. With this fix, those elements are added to the animation queue so they are present when the animation beings.

Before :

before.mov

After:

after.mov

I added a new parameter to the signature of the updateContentInset function for the animation duration with a default value of the inherited duration temporarily. The final implementation should contemplate updating the InputAccessoryViewPlaceholderDelegate protocol, adding the animation duration argument to the methods inputAccessoryPlaceholderKeyboardDidPresent and inputAccessoryPlaceholderKeyboardDidDismiss functions in order to pass that value to the updateContentInset method. I avoided this in order to keep this PR short and have room for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant