Concord JSHint Standards with Signal-Desktop, update to ES6 getPrototypeOf #48
Conversation
PunkChameleon
changed the title
|
@scottnonnenberg-signal @gasi-signal is there any chance you'd be able to review / test locally? |
|
@scottnonnenberg-signal @gasi-signal -- nix the automated test part. After figuring out #50 via #9, was able to run tests locally and all have passed. |
|
@scottnonnenberg-signal is this project frozen? |
|
I suppose you might call it that. We only really make changes when we need to, since there's a high risk of breaking things. Maybe you could talk about the high-level reason for this change? |
|
@scottnonnenberg-signal -- makes sense. This change essentially concords the style guides for Signal's other JS repos, and updates a legacy aspect of the old library to use new ES6 standards. |
|
Just following-up on this. Helpful? |
|
@scottnonnenberg-signal is this useful to merge? |
Attempt to rectify both JSHint profiles between here and Signal-Desktop.
This upgrades the file to match, and then removes the legacy 'proto' and invokes the new ES6
.getPrototypeOf()method.An extra pair of eyes for testing this would be helpful -- my machine is having trouble closing the SauceLabs tunnel but I believe they're passing regardless. Sanity checks are welcome!